Sign upLogin

fastladder/fastladder

View on GitHub
Star
app/assets/javascripts/lib/events/hotkey.js

Summary

Maintainability
D
1 day
Test Coverage

Function kc2char has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

HotKey.kc2char = function(kc){
    var between = function(a,b){
        return a <= kc && kc <= b
    }
    var _32_40 = "space pageup pagedown end home left up right down".split(" ");
Severity: Minor
Found in app/assets/javascripts/lib/events/hotkey.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

HotKey.prototype.init = function(){
    var self = this;
    var target = this._target;
    var cancelNext;
    var state = "";
Severity: Minor
Found in app/assets/javascripts/lib/events/hotkey.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

HotKey.prototype.init = function(){
    var self = this;
    var target = this._target;
    var cancelNext;
    var state = "";
Severity: Minor
Found in app/assets/javascripts/lib/events/hotkey.js - About 1 hr to fix

    Function kc2char has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    HotKey.kc2char = function(kc){
    var between = function(a,b){
        return a <= kc && kc <= b
    }
    var _32_40 = "space pageup pagedown end home left up right down".split(" ");
    Severity: Minor
    Found in app/assets/javascripts/lib/events/hotkey.js - About 1 hr to fix

      Function get_input has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      HotKey.prototype.get_input = function(e){
    var el  = (e.target || e.srcElement);
    var tag = el.tagName;
    var id  = el.id;
    if(!this.allow.test(id) && this.ignore.test(tag)) return;
      Severity: Minor
      Found in app/assets/javascripts/lib/events/hotkey.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function specialCase has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      HotKey.specialCase = function(e){
    var kc = e.keyCode;
    if(e.type == "keypress" && e.keyCode == 27) return "esc";
    if(e.type == "keydown" && e.keyCode == 46)  return "delete";
    if(112 <= e.keyCode && e.keyCode <= 123){
      Severity: Minor
      Found in app/assets/javascripts/lib/events/hotkey.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      HotKey.prototype.add = function(key, func){
    if(key.constructor == Array){
        for(var i=0;i<key.length;i++)
            this.add(key[i], func)
    }else if(key.indexOf("|") != -1){
      Severity: Minor
      Found in app/assets/javascripts/lib/events/hotkey.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return false;
      Severity: Major
      Found in app/assets/javascripts/lib/events/hotkey.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            invoke_keypress : function(e){
        var listeners = HotKey.Base.KeypressListeners;
        for(var i=0;i<listeners.length;i++){
            listeners[i].call(this, e);
        }
        Severity: Major
        Found in app/assets/javascripts/lib/events/hotkey.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/lib/events/hotkey.js on lines 40..45

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            invoke_keydown : function(e){
        var listeners = HotKey.Base.KeydownListeners;
        for(var i=0;i<listeners.length;i++){
            listeners[i].call(this, e);
        }
        Severity: Major
        Found in app/assets/javascripts/lib/events/hotkey.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/lib/events/hotkey.js on lines 46..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status