Sign upLogin

fastladder/fastladder

View on GitHub
Star
app/assets/javascripts/lib/reader/widgets.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function setup_widgets has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setup_widgets(){
    channel_widgets.sep = "  |  "
    entry_widgets.sep = "";

    entry_widgets.add('created_on', function(feed, item){
Severity: Minor
Found in app/assets/javascripts/lib/reader/widgets.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        entry_widgets.add('subs_button', function(feed, item){
        var channel_domain = get_domain(feed.channel.link);
        var subs_button = function(url){
            return '<a href="' + url + '" rel="discover">登録</a>';
        };
    Severity: Major
    Found in app/assets/javascripts/lib/reader/widgets.js and 1 other location - About 2 hrs to fix
    app/assets/javascripts/lib/reader/widgets_en.js on lines 17..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        entry_widgets.add('modified_on', function(feed, item){
        if(item.created_on == item.modified_on) return;
        return '更新: ' + new DateTime(item.modified_on * 1000).toString();
    });
    Severity: Major
    Found in app/assets/javascripts/lib/reader/widgets.js and 1 other location - About 1 hr to fix
    app/assets/javascripts/lib/reader/widgets_en.js on lines 12..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        channel_widgets.add('touch_button', function(feed){
        if(app.config.touch_when != "manual") return;
        return [
            "<span class='button' onclick='touch_all(\"",feed.subscribe_id,"\")'>既読にする</span>"
        ].join("");
    Severity: Minor
    Found in app/assets/javascripts/lib/reader/widgets.js and 1 other location - About 55 mins to fix
    app/assets/javascripts/lib/reader/widgets_en.js on lines 68..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        entry_widgets.add('created_on', function(feed, item){
        return '投稿: ' + new DateTime(item.created_on * 1000).toString();
    });
    Severity: Minor
    Found in app/assets/javascripts/lib/reader/widgets.js and 1 other location - About 30 mins to fix
    app/assets/javascripts/lib/reader/widgets_en.js on lines 8..10

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status