Sign upLogin

fastladder/fastladder

View on GitHub
Star
app/assets/javascripts/lib/share/share.js

Summary

Maintainability
D
1 day
Test Coverage

File share.js has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

window.onload = init;
LDR.API.StickyQuery = { ApiKey: ApiKey };

var State = {};
State.offset = 0;
Severity: Minor
Found in app/assets/javascripts/lib/share/share.js - About 4 hrs to fix

    Function make_filter has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function make_filter(){
    var filters = [];
    function add_filter(f){
        filters.push(f);
    }
    Severity: Major
    Found in app/assets/javascripts/lib/share/share.js - About 2 hrs to fix

      Function make_filter has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function make_filter(){
    var filters = [];
    function add_filter(f){
        filters.push(f);
    }
      Severity: Minor
      Found in app/assets/javascripts/lib/share/share.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function init has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function init(){
    updater("filtered_subs_count", function(){
        this.innerHTML = FilteredSubs.length +" "+'items';
    });
    updater("filtered_subs", function(){
      Severity: Minor
      Found in app/assets/javascripts/lib/share/share.js - About 1 hr to fix

        Function setup_mspace has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function setup_mspace(){
    var rate_cell = _$("mspace_rate");
    var folder_cell = _$("mspace_folders");
    var rate_count = Subs.count_by_key("rate");
    var folder_count = Subs.count_by_key("folder");
        Severity: Minor
        Found in app/assets/javascripts/lib/share/share.js - About 1 hr to fix

          Function set_public has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function set_public(flag){
    if(progress) return;
    var api = new LDR.API("/api/feed/set_public");
    var selected = Subs.filter(function(sub){
        return (sub.selected && sub["public"] != flag);
          Severity: Minor
          Found in app/assets/javascripts/lib/share/share.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if(_$("filter_subscriber_max").value){
        var max = _$("filter_subscriber_max").value;
        add_filter(function(s){ return s.subscribers_count <= max })
    }
            Severity: Minor
            Found in app/assets/javascripts/lib/share/share.js and 1 other location - About 55 mins to fix
            app/assets/javascripts/lib/share/share.js on lines 186..189

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if(_$("filter_subscriber_min").value){
        var min = _$("filter_subscriber_min").value;
        add_filter(function(s){ return s.subscribers_count >= min })
    }
            Severity: Minor
            Found in app/assets/javascripts/lib/share/share.js and 1 other location - About 55 mins to fix
            app/assets/javascripts/lib/share/share.js on lines 190..193

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status