Sign upLogin

fastladder/fastladder

View on GitHub
Star
app/assets/javascripts/lib/subscribe/subscribe.js

Summary

Maintainability
F
5 days
Test Coverage

File subscribe.js has 476 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* LDR /subscribe/ */

ApiKey = document.querySelector('#ApiKey').dataset.apiKey;
LDR.API.StickyQuery = { ApiKey: ApiKey };
var LDReader = {};
Severity: Minor
Found in app/assets/javascripts/lib/subscribe/subscribe.js - About 7 hrs to fix

    Function subs_edit has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function subs_edit(e){
    var el = this;
    if(e){
        Event.stop(e);
    }
    Severity: Major
    Found in app/assets/javascripts/lib/subscribe/subscribe.js - About 2 hrs to fix

      Function subscribe_submit has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function subscribe_submit(e){
    if(!this.history_back.checked) return;

    var form = this;
    var folder_id = this.folder_id.value;
      Severity: Major
      Found in app/assets/javascripts/lib/subscribe/subscribe.js - About 2 hrs to fix

        Function round_corner has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function round_corner(el){
    el = _$(el);
    var browser = new BrowserDetect;
    if(browser.isFirefox){
        setStyle(el, {"-moz-border-radius" : "5px"});
        Severity: Minor
        Found in app/assets/javascripts/lib/subscribe/subscribe.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

              if(feedlink.length && feedlink_checkbox.length){
        Array.forEach(feedlink, function(el){
            Array.some(feedlink_checkbox, function(checkbox) {
                if (el.value === checkbox.value) {
                    return false;
          Severity: Critical
          Found in app/assets/javascripts/lib/subscribe/subscribe.js - About 1 hr to fix

            Function subscribe_submit has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            function subscribe_submit(e){
    if(!this.history_back.checked) return;

    var form = this;
    var folder_id = this.folder_id.value;
            Severity: Minor
            Found in app/assets/javascripts/lib/subscribe/subscribe.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function ajaxize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function ajaxize(element, callback){
    element = _$(element);
    var method = element.method;
    var action = element.getAttribute("action");
    // ひとつの場合は完了時処理
            Severity: Minor
            Found in app/assets/javascripts/lib/subscribe/subscribe.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            function ajaxize(element, callback){
    element = _$(element);
    var method = element.method;
    var action = element.getAttribute("action");
    // ひとつの場合は完了時処理
            Severity: Major
            Found in app/assets/javascripts/lib/subscribe/subscribe.js and 1 other location - About 1 day to fix
            app/assets/javascripts/lib/reader/ajax.js on lines 18..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 233.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            function Pipe(label){
    var q = [];
    Pipe["_" + label] = q;
    var f = function(arg){
        var result = arg;
            Severity: Major
            Found in app/assets/javascripts/lib/subscribe/subscribe.js and 1 other location - About 3 hrs to fix
            app/assets/javascripts/lib/reader/ajax.js on lines 87..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            Rate.hover = function(e){
    var el = this;
    if(!el.getAttribute("orig_src")){
        el.setAttribute("orig_src",el.src);
    }
            Severity: Major
            Found in app/assets/javascripts/lib/subscribe/subscribe.js and 1 other location - About 3 hrs to fix
            app/assets/javascripts/lib/ui/rate.js on lines 40..47

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            if(browser.isKHTML){
    ajax.filter.add(function(t){
        var esc = escape(t);
        return(esc.indexOf("%u") < 0 && esc.indexOf("%") > -1) ? decodeURIComponent(esc) : t
    })
            Severity: Major
            Found in app/assets/javascripts/lib/subscribe/subscribe.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/lib/reader/ajax.js on lines 47..52

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 86.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var show = function(){
        el.checked = true;
        el.style.display = "inline";
        _$("label_"+el.id).style.display = "inline";
    }
            Severity: Major
            Found in app/assets/javascripts/lib/subscribe/subscribe.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/lib/subscribe/subscribe.js on lines 378..382

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var hide = function(){
        el.checked = false;
        el.style.display = "none";
        _$("label_"+el.id).style.display = "none";
    };
            Severity: Major
            Found in app/assets/javascripts/lib/subscribe/subscribe.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/lib/subscribe/subscribe.js on lines 383..387

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            Rate.out = function(e){
    var src;
    var el = this;
    if(src = el.getAttribute("orig_src")){
        el.src = src
            Severity: Major
            Found in app/assets/javascripts/lib/subscribe/subscribe.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/lib/ui/rate.js on lines 33..39

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status