fastladder/fastladder

View on GitHub

Showing 137 of 237 total issues

Function print_discover has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function print_discover(list){
    var output = _$("discover_items");
    var sub   = Template.get("discover_select_sub").compile()
    var unsub = Template.get("discover_select_unsub").compile()
    if(list.length == 0){
Severity: Minor
Found in app/assets/javascripts/lib/reader/main.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toRelativeDate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

Number.prototype.toRelativeDate = function(){
    var k = this > 0 ? this : -this;
    var u = "sec";
    var jp = {
        sec : "秒",
Severity: Minor
Found in app/assets/javascripts/lib/utils/proto.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method move has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def move
    dest = params[:to]
    if dest.blank?
      folder_id = nil
    else
Severity: Minor
Found in app/controllers/api/feed_controller.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setCookie has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function setCookie(name,value,expires,path,domain,secure){
Severity: Minor
Found in app/assets/javascripts/lib/utils/common.js - About 45 mins to fix

    Method run_body has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def run_body
          @logger.info "sleep: #{@interval}s"
          sleep @interval
          if feed = CrawlStatus.fetch_crawlable_feed
            @interval = 0
    Severity: Minor
    Found in lib/fastladder/fastladder_crawler.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run_body has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def run_body
          @logger.info "sleep: #{@interval}s"
          sleep @interval
          if feed = CrawlStatus.fetch_crawlable_feed
            @interval = 0
    Severity: Minor
    Found in lib/fastladder/crawler.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ajaxize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function ajaxize(element, callback){
        element = _$(element);
        var method = element.method;
        var action = element.getAttribute("action");
        // ひとつの場合は完了時処理
    Severity: Minor
    Found in app/assets/javascripts/lib/reader/ajax.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method as_json has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def as_json(options = {})
        result = {}
        result[:created_on] = self.created_on ? self.created_on.to_time.to_i : 0
        result[:modified_on] = self.modified_on ? self.modified_on.to_time.to_i : 0
        result[:id] = self.id
    Severity: Minor
    Found in app/models/item.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function page has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      page: function(forElement) {
        var valueT = 0, valueL = 0;
    
        var element = forElement;
        do {
    Severity: Minor
    Found in app/assets/javascripts/lib/utils/common.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function next_item has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        next_item: function(){
            this.unfocus();
            // roll
            var self = this;
            // 次のページをロード
    Severity: Minor
    Found in app/assets/javascripts/lib/reader/addon.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method all has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def all
        if params[:limit].blank?
          limit = Settings.max_unread_count
        else
          limit = params[:limit].to_i
    Severity: Minor
    Found in app/controllers/api_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function BrowserDetect has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function BrowserDetect(){
        var ua = navigator.userAgent;
        if(ua.indexOf( "KHTML" ) > -1) this.isKHTML = true;
        if(ua.indexOf( "Macintosh" ) > -1) this.isMac   = true;
        if(ua.indexOf( "Windows" ) > -1) this.isWin   = true;
    Severity: Minor
    Found in app/assets/javascripts/lib/utils/common.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_input has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    HotKey.prototype.get_input = function(e){
        var el  = (e.target || e.srcElement);
        var tag = el.tagName;
        var id  = el.id;
        if(!this.allow.test(id) && this.ignore.test(tag)) return;
    Severity: Minor
    Found in app/assets/javascripts/lib/events/hotkey.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function mark_all_read has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        mark_all_read: function(){
            var list = Ordered.list;
            if(!list) return;
            var no_feeds = 'There is no item to mark as read';
            if(list.length == 0){
    Severity: Minor
    Found in app/assets/javascripts/lib/reader/commands.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function specialCase has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    HotKey.specialCase = function(e){
        var kc = e.keyCode;
        if(e.type == "keypress" && e.keyCode == 27) return "esc";
        if(e.type == "keydown" && e.keyCode == 46)  return "delete";
        if(112 <= e.keyCode && e.keyCode <= 123){
    Severity: Minor
    Found in app/assets/javascripts/lib/events/hotkey.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function select has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        select : function(id){
            if(this.folder_id == id){
                this.folder_id = null;
            } else {
                this.folder_id = id;
    Severity: Minor
    Found in app/assets/javascripts/lib/reader/manage.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ajaxize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    function ajaxize(element, callback){
        element = _$(element);
        var method = element.method;
        var action = element.getAttribute("action");
        // ひとつの場合は完了時処理
    Severity: Minor
    Found in app/assets/javascripts/lib/subscribe/subscribe.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    HotKey.prototype.add = function(key, func){
        if(key.constructor == Array){
            for(var i=0;i<key.length;i++)
                this.add(key[i], func)
        }else if(key.indexOf("|") != -1){
    Severity: Minor
    Found in app/assets/javascripts/lib/events/hotkey.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def setter
        if (pub = params[:member_public]) and pub =~ /^[01]$/
          @member.public = pub.to_i != 0
        end
        config = @member.config_dump || {}
    Severity: Minor
    Found in app/controllers/api/config_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fetch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def fetch(link, options = {})
        uri = link.kind_of?(URI) ? link : URI.parse(link)
    
        http_class = Net::HTTP
        # if proxy = uri.find_proxy || Fastladder.http_proxy
    Severity: Minor
    Found in lib/fastladder.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language