fbi-cde/crime-data-frontend

View on GitHub
src/components/UcrResourcesList.js

Summary

Maintainability
A
1 hr
Test Coverage

Function participationCsvLink has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const participationCsvLink = (place, type, states, participation) => {
  if (type === 'agency') return []
  if (type === 'region') return []

  const clickHander = () => {
Severity: Minor
Found in src/components/UcrResourcesList.js - About 1 hr to fix

    'API' is defined but never used.
    Open

    import { API } from '../util/api'
    Severity: Minor
    Found in src/components/UcrResourcesList.js by eslint

    Disallow Unused Variables (no-unused-vars)

    Variables that are declared and not used anywhere in the code are most likely an error due to incomplete refactoring. Such variables take up space in the code and can lead to confusion by readers.

    Rule Details

    This rule is aimed at eliminating unused variables, functions, and parameters of functions.

    A variable is considered to be used if any of the following are true:

    • It represents a function that is called (doSomething())
    • It is read (var y = x)
    • It is passed into a function as an argument (doSomething(x))
    • It is read inside of a function that is passed to another function (doSomething(function() { foo(); }))

    A variable is not considered to be used if it is only ever assigned to (var x = 5) or declared.

    Examples of incorrect code for this rule:

    /*eslint no-unused-vars: "error"*/
    /*global some_unused_var*/
    
    // It checks variables you have defined as global
    some_unused_var = 42;
    
    var x;
    
    // Write-only variables are not considered as used.
    var y = 10;
    y = 5;
    
    // A read for a modification of itself is not considered as used.
    var z = 0;
    z = z + 1;
    
    // By default, unused arguments cause warnings.
    (function(foo) {
        return 5;
    })();
    
    // Unused recursive functions also cause warnings.
    function fact(n) {
        if (n < 2) return 1;
        return n * fact(n - 1);
    }
    
    // When a function definition destructures an array, unused entries from the array also cause warnings.
    function getY([x, y]) {
        return y;
    }

    Examples of correct code for this rule:

    /*eslint no-unused-vars: "error"*/
    
    var x = 10;
    alert(x);
    
    // foo is considered used here
    myFunc(function foo() {
        // ...
    }.bind(this));
    
    (function(foo) {
        return foo;
    })();
    
    var myFunc;
    myFunc = setTimeout(function() {
        // myFunc is considered used
        myFunc();
    }, 50);
    
    // Only the second argument from the descructured array is used.
    function getY([, y]) {
        return y;
    }

    exported

    In environments outside of CommonJS or ECMAScript modules, you may use var to create a global variable that may be used by other scripts. You can use the /* exported variableName */ comment block to indicate that this variable is being exported and therefore should not be considered unused.

    Note that /* exported */ has no effect for any of the following:

    • when the environment is node or commonjs
    • when parserOptions.sourceType is module
    • when ecmaFeatures.globalReturn is true

    The line comment // exported variableName will not work as exported is not line-specific.

    Examples of correct code for /* exported variableName */ operation:

    /* exported global_var */
    
    var global_var = 42;

    Options

    This rule takes one argument which can be a string or an object. The string settings are the same as those of the vars property (explained below).

    By default this rule is enabled with all option for variables and after-used for arguments.

    {
        "rules": {
            "no-unused-vars": ["error", { "vars": "all", "args": "after-used", "ignoreRestSiblings": false }]
        }
    }

    vars

    The vars option has two settings:

    • all checks all variables for usage, including those in the global scope. This is the default setting.
    • local checks only that locally-declared variables are used but will allow global variables to be unused.

    vars: local

    Examples of correct code for the { "vars": "local" } option:

    /*eslint no-unused-vars: ["error", { "vars": "local" }]*/
    /*global some_unused_var */
    
    some_unused_var = 42;

    varsIgnorePattern

    The varsIgnorePattern option specifies exceptions not to check for usage: variables whose names match a regexp pattern. For example, variables whose names contain ignored or Ignored.

    Examples of correct code for the { "varsIgnorePattern": "[iI]gnored" } option:

    /*eslint no-unused-vars: ["error", { "varsIgnorePattern": "[iI]gnored" }]*/
    
    var firstVarIgnored = 1;
    var secondVar = 2;
    console.log(secondVar);

    args

    The args option has three settings:

    • after-used - only the last argument must be used. This allows you, for instance, to have two named parameters to a function and as long as you use the second argument, ESLint will not warn you about the first. This is the default setting.
    • all - all named arguments must be used.
    • none - do not check arguments.

    args: after-used

    Examples of incorrect code for the default { "args": "after-used" } option:

    /*eslint no-unused-vars: ["error", { "args": "after-used" }]*/
    
    // 1 error
    // "baz" is defined but never used
    (function(foo, bar, baz) {
        return bar;
    })();

    Examples of correct code for the default { "args": "after-used" } option:

    /*eslint no-unused-vars: ["error", {"args": "after-used"}]*/
    
    (function(foo, bar, baz) {
        return baz;
    })();

    args: all

    Examples of incorrect code for the { "args": "all" } option:

    /*eslint no-unused-vars: ["error", { "args": "all" }]*/
    
    // 2 errors
    // "foo" is defined but never used
    // "baz" is defined but never used
    (function(foo, bar, baz) {
        return bar;
    })();

    args: none

    Examples of correct code for the { "args": "none" } option:

    /*eslint no-unused-vars: ["error", { "args": "none" }]*/
    
    (function(foo, bar, baz) {
        return bar;
    })();

    ignoreRestSiblings

    The ignoreRestSiblings option is a boolean (default: false). Using a Rest Property it is possible to "omit" properties from an object, but by default the sibling properties are marked as "unused". With this option enabled the rest property's siblings are ignored.

    Examples of correct code for the { "ignoreRestSiblings": true } option:

    /*eslint no-unused-vars: ["error", { "ignoreRestSiblings": true }]*/
    // 'type' is ignored because it has a rest property sibling.
    var { type, ...coords } = data;

    argsIgnorePattern

    The argsIgnorePattern option specifies exceptions not to check for usage: arguments whose names match a regexp pattern. For example, variables whose names begin with an underscore.

    Examples of correct code for the { "argsIgnorePattern": "^_" } option:

    /*eslint no-unused-vars: ["error", { "argsIgnorePattern": "^_" }]*/
    
    function foo(x, _y) {
        return x + 1;
    }
    foo();

    caughtErrors

    The caughtErrors option is used for catch block arguments validation.

    It has two settings:

    • none - do not check error objects. This is the default setting.
    • all - all named arguments must be used.

    caughtErrors: none

    Not specifying this rule is equivalent of assigning it to none.

    Examples of correct code for the { "caughtErrors": "none" } option:

    /*eslint no-unused-vars: ["error", { "caughtErrors": "none" }]*/
    
    try {
        //...
    } catch (err) {
        console.error("errors");
    }

    caughtErrors: all

    Examples of incorrect code for the { "caughtErrors": "all" } option:

    /*eslint no-unused-vars: ["error", { "caughtErrors": "all" }]*/
    
    // 1 error
    // "err" is defined but never used
    try {
        //...
    } catch (err) {
        console.error("errors");
    }

    caughtErrorsIgnorePattern

    The caughtErrorsIgnorePattern option specifies exceptions not to check for usage: catch arguments whose names match a regexp pattern. For example, variables whose names begin with a string 'ignore'.

    Examples of correct code for the { "caughtErrorsIgnorePattern": "^ignore" } option:

    /*eslint no-unused-vars: ["error", { "caughtErrorsIgnorePattern": "^ignore" }]*/
    
    try {
        //...
    } catch (ignoreErr) {
        console.error("errors");
    }

    When Not To Use It

    If you don't want to be notified about unused variables or function arguments, you can safely turn this rule off. Source: http://eslint.org/docs/rules/

    'lookupStateByName' is defined but never used.
    Open

    import { lookupStateByName } from '../util/location'
    Severity: Minor
    Found in src/components/UcrResourcesList.js by eslint

    Disallow Unused Variables (no-unused-vars)

    Variables that are declared and not used anywhere in the code are most likely an error due to incomplete refactoring. Such variables take up space in the code and can lead to confusion by readers.

    Rule Details

    This rule is aimed at eliminating unused variables, functions, and parameters of functions.

    A variable is considered to be used if any of the following are true:

    • It represents a function that is called (doSomething())
    • It is read (var y = x)
    • It is passed into a function as an argument (doSomething(x))
    • It is read inside of a function that is passed to another function (doSomething(function() { foo(); }))

    A variable is not considered to be used if it is only ever assigned to (var x = 5) or declared.

    Examples of incorrect code for this rule:

    /*eslint no-unused-vars: "error"*/
    /*global some_unused_var*/
    
    // It checks variables you have defined as global
    some_unused_var = 42;
    
    var x;
    
    // Write-only variables are not considered as used.
    var y = 10;
    y = 5;
    
    // A read for a modification of itself is not considered as used.
    var z = 0;
    z = z + 1;
    
    // By default, unused arguments cause warnings.
    (function(foo) {
        return 5;
    })();
    
    // Unused recursive functions also cause warnings.
    function fact(n) {
        if (n < 2) return 1;
        return n * fact(n - 1);
    }
    
    // When a function definition destructures an array, unused entries from the array also cause warnings.
    function getY([x, y]) {
        return y;
    }

    Examples of correct code for this rule:

    /*eslint no-unused-vars: "error"*/
    
    var x = 10;
    alert(x);
    
    // foo is considered used here
    myFunc(function foo() {
        // ...
    }.bind(this));
    
    (function(foo) {
        return foo;
    })();
    
    var myFunc;
    myFunc = setTimeout(function() {
        // myFunc is considered used
        myFunc();
    }, 50);
    
    // Only the second argument from the descructured array is used.
    function getY([, y]) {
        return y;
    }

    exported

    In environments outside of CommonJS or ECMAScript modules, you may use var to create a global variable that may be used by other scripts. You can use the /* exported variableName */ comment block to indicate that this variable is being exported and therefore should not be considered unused.

    Note that /* exported */ has no effect for any of the following:

    • when the environment is node or commonjs
    • when parserOptions.sourceType is module
    • when ecmaFeatures.globalReturn is true

    The line comment // exported variableName will not work as exported is not line-specific.

    Examples of correct code for /* exported variableName */ operation:

    /* exported global_var */
    
    var global_var = 42;

    Options

    This rule takes one argument which can be a string or an object. The string settings are the same as those of the vars property (explained below).

    By default this rule is enabled with all option for variables and after-used for arguments.

    {
        "rules": {
            "no-unused-vars": ["error", { "vars": "all", "args": "after-used", "ignoreRestSiblings": false }]
        }
    }

    vars

    The vars option has two settings:

    • all checks all variables for usage, including those in the global scope. This is the default setting.
    • local checks only that locally-declared variables are used but will allow global variables to be unused.

    vars: local

    Examples of correct code for the { "vars": "local" } option:

    /*eslint no-unused-vars: ["error", { "vars": "local" }]*/
    /*global some_unused_var */
    
    some_unused_var = 42;

    varsIgnorePattern

    The varsIgnorePattern option specifies exceptions not to check for usage: variables whose names match a regexp pattern. For example, variables whose names contain ignored or Ignored.

    Examples of correct code for the { "varsIgnorePattern": "[iI]gnored" } option:

    /*eslint no-unused-vars: ["error", { "varsIgnorePattern": "[iI]gnored" }]*/
    
    var firstVarIgnored = 1;
    var secondVar = 2;
    console.log(secondVar);

    args

    The args option has three settings:

    • after-used - only the last argument must be used. This allows you, for instance, to have two named parameters to a function and as long as you use the second argument, ESLint will not warn you about the first. This is the default setting.
    • all - all named arguments must be used.
    • none - do not check arguments.

    args: after-used

    Examples of incorrect code for the default { "args": "after-used" } option:

    /*eslint no-unused-vars: ["error", { "args": "after-used" }]*/
    
    // 1 error
    // "baz" is defined but never used
    (function(foo, bar, baz) {
        return bar;
    })();

    Examples of correct code for the default { "args": "after-used" } option:

    /*eslint no-unused-vars: ["error", {"args": "after-used"}]*/
    
    (function(foo, bar, baz) {
        return baz;
    })();

    args: all

    Examples of incorrect code for the { "args": "all" } option:

    /*eslint no-unused-vars: ["error", { "args": "all" }]*/
    
    // 2 errors
    // "foo" is defined but never used
    // "baz" is defined but never used
    (function(foo, bar, baz) {
        return bar;
    })();

    args: none

    Examples of correct code for the { "args": "none" } option:

    /*eslint no-unused-vars: ["error", { "args": "none" }]*/
    
    (function(foo, bar, baz) {
        return bar;
    })();

    ignoreRestSiblings

    The ignoreRestSiblings option is a boolean (default: false). Using a Rest Property it is possible to "omit" properties from an object, but by default the sibling properties are marked as "unused". With this option enabled the rest property's siblings are ignored.

    Examples of correct code for the { "ignoreRestSiblings": true } option:

    /*eslint no-unused-vars: ["error", { "ignoreRestSiblings": true }]*/
    // 'type' is ignored because it has a rest property sibling.
    var { type, ...coords } = data;

    argsIgnorePattern

    The argsIgnorePattern option specifies exceptions not to check for usage: arguments whose names match a regexp pattern. For example, variables whose names begin with an underscore.

    Examples of correct code for the { "argsIgnorePattern": "^_" } option:

    /*eslint no-unused-vars: ["error", { "argsIgnorePattern": "^_" }]*/
    
    function foo(x, _y) {
        return x + 1;
    }
    foo();

    caughtErrors

    The caughtErrors option is used for catch block arguments validation.

    It has two settings:

    • none - do not check error objects. This is the default setting.
    • all - all named arguments must be used.

    caughtErrors: none

    Not specifying this rule is equivalent of assigning it to none.

    Examples of correct code for the { "caughtErrors": "none" } option:

    /*eslint no-unused-vars: ["error", { "caughtErrors": "none" }]*/
    
    try {
        //...
    } catch (err) {
        console.error("errors");
    }

    caughtErrors: all

    Examples of incorrect code for the { "caughtErrors": "all" } option:

    /*eslint no-unused-vars: ["error", { "caughtErrors": "all" }]*/
    
    // 1 error
    // "err" is defined but never used
    try {
        //...
    } catch (err) {
        console.error("errors");
    }

    caughtErrorsIgnorePattern

    The caughtErrorsIgnorePattern option specifies exceptions not to check for usage: catch arguments whose names match a regexp pattern. For example, variables whose names begin with a string 'ignore'.

    Examples of correct code for the { "caughtErrorsIgnorePattern": "^ignore" } option:

    /*eslint no-unused-vars: ["error", { "caughtErrorsIgnorePattern": "^ignore" }]*/
    
    try {
        //...
    } catch (ignoreErr) {
        console.error("errors");
    }

    When Not To Use It

    If you don't want to be notified about unused variables or function arguments, you can safely turn this rule off. Source: http://eslint.org/docs/rules/

    'content' is already declared in the upper scope.
    Open

          .then(content => {
    Severity: Minor
    Found in src/components/UcrResourcesList.js by eslint

    disallow variable declarations from shadowing variables declared in the outer scope (no-shadow)

    Shadowing is the process by which a local variable shares the same name as a variable in its containing scope. For example:

    var a = 3;
    function b() {
        var a = 10;
    }

    In this case, the variable a inside of b() is shadowing the variable a in the global scope. This can cause confusion while reading the code and it's impossible to access the global variable.

    Rule Details

    This rule aims to eliminate shadowed variable declarations.

    Examples of incorrect code for this rule:

    /*eslint no-shadow: "error"*/
    /*eslint-env es6*/
    
    var a = 3;
    function b() {
        var a = 10;
    }
    
    var b = function () {
        var a = 10;
    }
    
    function b(a) {
        a = 10;
    }
    b(a);
    
    if (true) {
        let a = 5;
    }

    Options

    This rule takes one option, an object, with properties "builtinGlobals", "hoist" and "allow".

    {
        "no-shadow": ["error", { "builtinGlobals": false, "hoist": "functions", "allow": [] }]
    }

    builtinGlobals

    The builtinGlobals option is false by default. If it is true, the rule prevents shadowing of built-in global variables: Object, Array, Number, and so on.

    Examples of incorrect code for the { "builtinGlobals": true } option:

    /*eslint no-shadow: ["error", { "builtinGlobals": true }]*/
    
    function foo() {
        var Object = 0;
    }

    hoist

    The hoist option has three settings:

    • functions (by default) - reports shadowing before the outer functions are defined.
    • all - reports all shadowing before the outer variables/functions are defined.
    • never - never report shadowing before the outer variables/functions are defined.

    hoist: functions

    Examples of incorrect code for the default { "hoist": "functions" } option:

    /*eslint no-shadow: ["error", { "hoist": "functions" }]*/
    /*eslint-env es6*/
    
    if (true) {
        let b = 6;
    }
    
    function b() {}

    Although let b in the if statement is before the function declaration in the outer scope, it is incorrect.

    Examples of correct code for the default { "hoist": "functions" } option:

    /*eslint no-shadow: ["error", { "hoist": "functions" }]*/
    /*eslint-env es6*/
    
    if (true) {
        let a = 3;
    }
    
    let a = 5;

    Because let a in the if statement is before the variable declaration in the outer scope, it is correct.

    hoist: all

    Examples of incorrect code for the { "hoist": "all" } option:

    /*eslint no-shadow: ["error", { "hoist": "all" }]*/
    /*eslint-env es6*/
    
    if (true) {
        let a = 3;
        let b = 6;
    }
    
    let a = 5;
    function b() {}

    hoist: never

    Examples of correct code for the { "hoist": "never" } option:

    /*eslint no-shadow: ["error", { "hoist": "never" }]*/
    /*eslint-env es6*/
    
    if (true) {
        let a = 3;
        let b = 6;
    }
    
    let a = 5;
    function b() {}

    Because let a and let b in the if statement are before the declarations in the outer scope, they are correct.

    allow

    The allow option is an array of identifier names for which shadowing is allowed. For example, "resolve", "reject", "done", "cb".

    Examples of correct code for the { "allow": ["done"] } option:

    /*eslint no-shadow: ["error", { "allow": ["done"] }]*/
    /*eslint-env es6*/
    
    import async from 'async';
    
    function foo(done) {
      async.map([1, 2], function (e, done) {
        done(null, e * 2)
      }, done);
    }
    
    foo(function (err, result) {
      console.log({ err, result });
    });

    Further Reading

    Related Rules

    'content' is already declared in the upper scope.
    Open

        const content = jsonToCsv(data)
    Severity: Minor
    Found in src/components/UcrResourcesList.js by eslint

    disallow variable declarations from shadowing variables declared in the outer scope (no-shadow)

    Shadowing is the process by which a local variable shares the same name as a variable in its containing scope. For example:

    var a = 3;
    function b() {
        var a = 10;
    }

    In this case, the variable a inside of b() is shadowing the variable a in the global scope. This can cause confusion while reading the code and it's impossible to access the global variable.

    Rule Details

    This rule aims to eliminate shadowed variable declarations.

    Examples of incorrect code for this rule:

    /*eslint no-shadow: "error"*/
    /*eslint-env es6*/
    
    var a = 3;
    function b() {
        var a = 10;
    }
    
    var b = function () {
        var a = 10;
    }
    
    function b(a) {
        a = 10;
    }
    b(a);
    
    if (true) {
        let a = 5;
    }

    Options

    This rule takes one option, an object, with properties "builtinGlobals", "hoist" and "allow".

    {
        "no-shadow": ["error", { "builtinGlobals": false, "hoist": "functions", "allow": [] }]
    }

    builtinGlobals

    The builtinGlobals option is false by default. If it is true, the rule prevents shadowing of built-in global variables: Object, Array, Number, and so on.

    Examples of incorrect code for the { "builtinGlobals": true } option:

    /*eslint no-shadow: ["error", { "builtinGlobals": true }]*/
    
    function foo() {
        var Object = 0;
    }

    hoist

    The hoist option has three settings:

    • functions (by default) - reports shadowing before the outer functions are defined.
    • all - reports all shadowing before the outer variables/functions are defined.
    • never - never report shadowing before the outer variables/functions are defined.

    hoist: functions

    Examples of incorrect code for the default { "hoist": "functions" } option:

    /*eslint no-shadow: ["error", { "hoist": "functions" }]*/
    /*eslint-env es6*/
    
    if (true) {
        let b = 6;
    }
    
    function b() {}

    Although let b in the if statement is before the function declaration in the outer scope, it is incorrect.

    Examples of correct code for the default { "hoist": "functions" } option:

    /*eslint no-shadow: ["error", { "hoist": "functions" }]*/
    /*eslint-env es6*/
    
    if (true) {
        let a = 3;
    }
    
    let a = 5;

    Because let a in the if statement is before the variable declaration in the outer scope, it is correct.

    hoist: all

    Examples of incorrect code for the { "hoist": "all" } option:

    /*eslint no-shadow: ["error", { "hoist": "all" }]*/
    /*eslint-env es6*/
    
    if (true) {
        let a = 3;
        let b = 6;
    }
    
    let a = 5;
    function b() {}

    hoist: never

    Examples of correct code for the { "hoist": "never" } option:

    /*eslint no-shadow: ["error", { "hoist": "never" }]*/
    /*eslint-env es6*/
    
    if (true) {
        let a = 3;
        let b = 6;
    }
    
    let a = 5;
    function b() {}

    Because let a and let b in the if statement are before the declarations in the outer scope, they are correct.

    allow

    The allow option is an array of identifier names for which shadowing is allowed. For example, "resolve", "reject", "done", "cb".

    Examples of correct code for the { "allow": ["done"] } option:

    /*eslint no-shadow: ["error", { "allow": ["done"] }]*/
    /*eslint-env es6*/
    
    import async from 'async';
    
    function foo(done) {
      async.map([1, 2], function (e, done) {
        done(null, e * 2)
      }, done);
    }
    
    foo(function (err, result) {
      console.log({ err, result });
    });

    Further Reading

    Related Rules

    Visible, non-interactive elements should not have mouse or keyboard event listeners
    Open

          <a
    Severity: Minor
    Found in src/components/UcrResourcesList.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status