Sign upLogin

feathersjs/feathers-authentication-oauth1

View on GitHub
Star

Showing 5 of 7 total issues

Function init has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function init (options = {}) {
  return function oauth1Auth () {
    const app = this;
    const _super = app.setup;
Severity: Major
Found in lib/index.js - About 2 hrs to fix

    Function oauth1Auth has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function oauth1Auth () {
    const app = this;
    const _super = app.setup;

    if (!app.passport) {
    Severity: Major
    Found in lib/index.js - About 2 hrs to fix

      Function init has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      function init (options = {}) {
  return function oauth1Auth () {
    const app = this;
    const _super = app.setup;
      Severity: Minor
      Found in lib/index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function verify has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        verify (req, accessToken, refreshToken, profile, done) {
    debug('Checking credentials');
    const options = this.options;
    const query = {
      [options.idField]: profile.id, // facebookId: profile.id
      Severity: Minor
      Found in lib/verifier.js - About 1 hr to fix

        Function verify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          verify (req, accessToken, refreshToken, profile, done) {
    debug('Checking credentials');
    const options = this.options;
    const query = {
      [options.idField]: profile.id, // facebookId: profile.id
        Severity: Minor
        Found in lib/verifier.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language