feathersjs/feathers-reactive

View on GitHub

Showing 6 of 6 total issues

Function strategies has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

export function strategies<T>() {
  return {
    // created$: new Observable<T>(),
    // updated$: new Observable<T>(),
    // patched$: new Observable<T>(),
Severity: Minor
Found in src/strategies.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function strategies has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function strategies<T>() {
  return {
    // created$: new Observable<T>(),
    // updated$: new Observable<T>(),
    // patched$: new Observable<T>(),
Severity: Major
Found in src/strategies.ts - About 4 hrs to fix

    Function smart has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        smart(source$: Observable<T>, options, args) {
          const params = args[0] || {};
          const query = Object.assign({}, params.query);
          // A function that returns if an item matches the query
          const matches = options.matcher(query);
    Severity: Major
    Found in src/strategies.ts - About 3 hrs to fix

      Function mixin has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const mixin = function (service: ServiceAddons) {
          const events = {
            // fromEvent's result selector (3rd arg) is deprecated
            // we need it here because service events have an inconsistent number of arguments (i.e. sometimes 1, sometimes >1)
            // related: https://github.com/ReactiveX/rxjs/issues/3751
      Severity: Major
      Found in src/index.ts - About 2 hrs to fix

        Function reactiveResource has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function reactiveResource(settings: Options, method: string) {
          return function () {
            const position = getParamsPosition(method);
            const params = arguments[position] || {};
        
        
        Severity: Minor
        Found in src/resource.ts - About 1 hr to fix

          Function rx has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          export function rx(
            options: Options = {
              idField: '_id'
            }
          ) {
          Severity: Minor
          Found in src/index.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language