Sign upLogin

fedspendingtransparency/usaspending-api

View on GitHub
Star

Showing 118 of 226 total issues

Function create_empty_data_file has 7 arguments (exceeds 6 allowed). Consider refactoring.
Open

def create_empty_data_file(
Severity: Major
Found in usaspending_api/download/filestreaming/download_generation.py - About 35 mins to fix

    Function log_dispatcher_message has 7 arguments (exceeds 6 allowed). Consider refactoring.
    Open

    def log_dispatcher_message(
    Severity: Major
    Found in usaspending_api/common/sqs/sqs_job_logging.py - About 35 mins to fix

      Function parse_cli_args has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
      Open

      def parse_cli_args(options: dict, es_client) -> dict:
    passthrough_values = [
        "create_new_index",
        "drop_db_view",
        "index_name",
      Severity: Minor
      Found in usaspending_api/etl/management/commands/elasticsearch_indexer.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function build_data_file_name has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
      Open

      def build_data_file_name(source, download_job, piid, assistance_id):
    if download_job and download_job.monthly_download:
        # For monthly archives, use the existing detailed zip filename for the data files
        # e.g. FY(All)-012_Contracts_Delta_20191108.zip -> FY(All)-012_Contracts_Delta_20191108_%.csv
        return strip_file_extension(download_job.file_name)
      Severity: Minor
      Found in usaspending_api/download/filestreaming/download_generation.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function generate_elasticsearch_query has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
      Open

          def generate_elasticsearch_query(cls, filter_values: List[dict], query_type: _QueryType, **options) -> ES_Q:
        recipient_locations_query = []

        for filter_value in filter_values:
            location_query = []
      Severity: Minor
      Found in usaspending_api/common/query_with_filters.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function load_data_into_model has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
      Open

          def load_data_into_model(self, model_instance, fields, field_map, value_map, row, logger, as_dict=False):
        mod = model_instance

        if as_dict:
            mod = {}
      Severity: Minor
      Found in usaspending_api/common/threaded_data_loader.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                      return Q()
      Severity: Major
      Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return ~self.range_intersect(field, value)
        Severity: Major
        Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                              return ~fy.get_filter_object(field)
          Severity: Minor
          Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return ~Q(**q_kwargs)
            Severity: Major
            Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return Q(**q_kwargs)
              Severity: Major
              Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return 4
                Severity: Minor
                Found in usaspending_api/etl/helpers.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return q_obj
                  Severity: Major
                  Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return fy.get_filter_object(field)
                    Severity: Major
                    Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return self.range_intersect(field, value)
                      Severity: Major
                      Found in usaspending_api/common/api_request_utils.py - About 30 mins to fix

                        Function get_business_categories_fabs has a Cognitive Complexity of 16 (exceeds 15 allowed). Consider refactoring.
                        Open

                        def get_business_categories_fabs(business_types):
    # This function is supposed to be invoked as a Spark UDF with the business_types field passed to it.

    business_category_set = set()
                        Severity: Minor
                        Found in usaspending_api/broker/helpers/get_business_categories.py - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function get_unreported_data_obj has a Cognitive Complexity of 16 (exceeds 15 allowed). Consider refactoring.
                        Open

                        def get_unreported_data_obj(
    queryset, filters, limit, spending_type, actual_total, fiscal_year, fiscal_period
) -> (list, float):
    """Returns the modified list of result objects including the object corresponding to the unreported amount, only
    if applicable. If the unreported amount does not fit within the limit of results provided, it will not be added.
                        Severity: Minor
                        Found in usaspending_api/spending_explorer/v2/filters/type_filter.py - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function post has a Cognitive Complexity of 16 (exceeds 15 allowed). Consider refactoring.
                        Open

                            def post(self, request):
        models = [
            {
                "name": "fields",
                "key": "fields",
                        Severity: Minor
                        Found in usaspending_api/search/v2/views/search_elasticsearch.py - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language