Sign upLogin

felixarntz/wp-gcs-offload

View on GitHub
Star

Showing 8 of 52 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

( function( wp, $, data ) {

    function create_sync_notice( message, type, notice_before_selector ) {
        var $notice_section = $( '<div id="wp-gcs-offload-sync-notice-wrap" class="misc-pub-section" />' );
        var $notice = $( '<div id="wp-gcs-offload-sync-notice" class="notice notice-' + type + '" />' );
Severity: Major
Found in assets/dist/js/attachment-edit.js and 1 other location - About 3 days to fix
assets/src/js/attachment-edit.js on lines 1..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 625.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

( function( wp, $, data ) {

    function create_sync_notice( message, type, notice_before_selector ) {
        var $notice_section = $( '<div id="wp-gcs-offload-sync-notice-wrap" class="misc-pub-section" />' );
        var $notice = $( '<div id="wp-gcs-offload-sync-notice" class="notice notice-' + type + '" />' );
Severity: Major
Found in assets/src/js/attachment-edit.js and 1 other location - About 3 days to fix
assets/dist/js/attachment-edit.js on lines 6..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 625.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var readmeheader =    'Plugin Name:       ' + config.pluginName + '\n' +
                    'Plugin URI:        ' + config.pluginURI + '\n' +
                    'Author:            ' + config.author + '\n' +
                    'Author URI:        ' + config.authorURI + '\n' +
                    'Contributors:      ' + config.contributors + '\n' +
Severity: Major
Found in gulpfile.js and 1 other location - About 2 hrs to fix
gulpfile.js on lines 45..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var pluginheader =     'Plugin Name: ' + config.pluginName + '\n' +
                    'Plugin URI:  ' + config.pluginURI + '\n' +
                    'Description: ' + config.description + '\n' +
                    'Version:     ' + config.version + '\n' +
                    'Author:      ' + config.author + '\n' +
Severity: Major
Found in gulpfile.js and 1 other location - About 2 hrs to fix
gulpfile.js on lines 58..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        public function ajax_delete_attachment_downstream( $data ) {
            $attachment = $this->ajax_get_attachment( $data );
            if ( is_wp_error( $attachment ) ) {
                return $attachment;
            }
Severity: Major
Found in inc/WPGCSOffload/Admin/AttachmentEdit.php and 3 other locations - About 1 hr to fix
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 134..154
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 156..176
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 178..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        public function ajax_delete_attachment_upstream( $data ) {
            $attachment = $this->ajax_get_attachment( $data );
            if ( is_wp_error( $attachment ) ) {
                return $attachment;
            }
Severity: Major
Found in inc/WPGCSOffload/Admin/AttachmentEdit.php and 3 other locations - About 1 hr to fix
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 134..154
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 156..176
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 200..220

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        public function ajax_sync_attachment_downstream( $data ) {
            $attachment = $this->ajax_get_attachment( $data );
            if ( is_wp_error( $attachment ) ) {
                return $attachment;
            }
Severity: Major
Found in inc/WPGCSOffload/Admin/AttachmentEdit.php and 3 other locations - About 1 hr to fix
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 134..154
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 178..198
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 200..220

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        public function ajax_sync_attachment_upstream( $data ) {
            $attachment = $this->ajax_get_attachment( $data );
            if ( is_wp_error( $attachment ) ) {
                return $attachment;
            }
Severity: Major
Found in inc/WPGCSOffload/Admin/AttachmentEdit.php and 3 other locations - About 1 hr to fix
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 156..176
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 178..198
inc/WPGCSOffload/Admin/AttachmentEdit.php on lines 200..220

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language