Sign upLogin

felixarntz/wp-site-identity

View on GitHub
Star
assets/dist/js/settings-page.js

Summary

Maintainability
F
1 wk
Test Coverage

Function openImageMediaModal has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function openImageMediaModal() {
        var field        = document.getElementById( this.dataset.target );
        var preview      = document.getElementById( this.dataset.target + '-preview' );
        var selectButton = this;
        var deleteButton = document.getElementById( this.dataset.target + '-delete-button' );
Severity: Minor
Found in assets/dist/js/settings-page.js - About 1 hr to fix

    Function initializeImageField has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function initializeImageField( field ) {
        var selectButton = document.createElement( 'button' );
        var deleteButton = document.createElement( 'button' );
        var value        = parseInt( field.value, 10 );
        var attachment   = document.getElementById( field.id + '-attachment-data' );
    Severity: Minor
    Found in assets/dist/js/settings-page.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      ( function( data ) {

    var typeRadios       = document.querySelectorAll( '#wpsi-owner-data-type input[type="radio"]' );
    var typeRadioChecked = document.querySelector( '#wpsi-owner-data-type input[type="radio"]:checked' );
    var colors           = document.querySelectorAll( '.form-table input[data-colorpicker]' );
      Severity: Major
      Found in assets/dist/js/settings-page.js and 1 other location - About 1 wk to fix
      assets/src/js/settings-page.js on lines 1..175

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 1774.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status