Sign upLogin

fewieden/MMM-Fuel

View on GitHub
Star
apis/nsw.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function getData has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

async function getData() {
    const responses = await Promise.all(config.types.map(requestFuelType));
    const collection = {};
    for (const response of responses) {
        collection[response.type] = mapPriceToStation(response.data);
Severity: Minor
Found in apis/nsw.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getData has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function getData() {
    const responses = await Promise.all(config.types.map(requestFuelType));
    const collection = {};
    for (const response of responses) {
        collection[response.type] = mapPriceToStation(response.data);
Severity: Minor
Found in apis/nsw.js - About 1 hr to fix

    Function mapPriceToStation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function mapPriceToStation({ stations, prices }) {
    for (const station of stations) {
        for (const price of prices) {
            if (station.code === price.stationcode) {
                station.price = price.price / 100;
    Severity: Minor
    Found in apis/nsw.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status