Sign upLogin

fewieden/MMM-NHL

View on GitHub
Star
node_helper.js

Summary

Maintainability
A
1 hr
Test Coverage

TODO found
Wontfix

                home: this.parsePlayoffTeam(series.matchupTeams, undefined), // TODO: Don't pass undefined to retrieve the correct score
Severity: Minor
Found in node_helper.js by fixme

TODO found
Wontfix

        // TODO: Find playoff endpoints in new API
Severity: Minor
Found in node_helper.js by fixme

TODO found
Wontfix

        // TODO: This function seems over complicated, don't we just have 1st 2nd and 3rd?
Severity: Minor
Found in node_helper.js by fixme

TODO found
Wontfix

                away: this.parsePlayoffTeam(series.matchupTeams, undefined), // TODO: Don't pass undefined to retrieve the correct score
Severity: Minor
Found in node_helper.js by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (!response.ok) {
            Log.error(`Initializing NHL teams failed: ${response.status} ${response.statusText}`);

            return;
        }
Severity: Minor
Found in node_helper.js and 1 other location - About 35 mins to fix
node_helper.js on lines 259..262

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (!response.ok) {
            Log.error(`Fetching NHL playoffs failed: ${response.status} ${response.statusText}.`);
            return;
        }
Severity: Minor
Found in node_helper.js and 1 other location - About 35 mins to fix
node_helper.js on lines 132..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Parsing error: Unexpected token .
Invalid

        return score?.clock?.inIntermission ? '00:00' : score?.clock?.timeRemaining;
Severity: Minor
Found in node_helper.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status