Sign upLogin

fewieden/MMM-ScottishPremierLeague

View on GitHub
Star

Showing 3 of 4 total issues

Function getDom has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
Open

    getDom() {
        const wrapper = document.createElement('div');

        if (this.loading ||
            !this.standing) {
Severity: Minor
Found in MMM-ScottishPremierLeague.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getDom has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getDom() {
        const wrapper = document.createElement('div');

        if (this.loading ||
            !this.standing) {
Severity: Major
Found in MMM-ScottishPremierLeague.js - About 4 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                            if (this.standing[i].Team[0] === this.config.focus_on) {
                            focusTeamIndex = i;
                            /* max_teams is set */
                            if (this.config.max_teams) {
                                const before = parseInt(this.config.max_teams / 2);
    Severity: Major
    Found in MMM-ScottishPremierLeague.js - About 45 mins to fix
      Severity
      Category
      Status
      Source
      Language