Sign upLogin

fey/materialized-path

View on GitHub
Star

Showing 11 of 13 total issues

File MaterializedPathTrait.php has 512 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace Langaner\MaterializedPath;

use App;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;
Severity: Major
Found in src/MaterializedPathTrait.php - About 1 day to fix

    Method updateNode has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function updateNode(Model $node)
    {
        if (!$node) {
            throw new NodeNotFoundException('Node doesnt exist');
        }
    Severity: Major
    Found in src/MaterializedPathTrait.php - About 2 hrs to fix

      Method makeFirstChildOf has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function makeFirstChildOf($parentId)
    {
        $parent = $this->newQuery()->find($parentId);

        if (!$parent) {
      Severity: Minor
      Found in src/MaterializedPathTrait.php - About 1 hr to fix

        Method makeLastChildOf has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function makeLastChildOf($parentId)
    {
        $parent = $this->newQuery()->find($parentId);

        if (!$parent) {
        Severity: Minor
        Found in src/MaterializedPathTrait.php - About 1 hr to fix

          Method processSiblingOf has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function processSiblingOf(Model $sibling, $op)
    {
        if ($this->exists and $this->isAncestorOf($sibling)) {
            throw new MoveException('Cant move Ancestor to Descendant');
        }
          Severity: Minor
          Found in src/MaterializedPathTrait.php - About 1 hr to fix

            Function updateNode has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function updateNode(Model $node)
    {
        if (!$node) {
            throw new NodeNotFoundException('Node doesnt exist');
        }
            Severity: Minor
            Found in src/MaterializedPathTrait.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function makeLastChildOf has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function makeLastChildOf($parentId)
    {
        $parent = $this->newQuery()->find($parentId);

        if (!$parent) {
            Severity: Minor
            Found in src/MaterializedPathTrait.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function processSiblingOf has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function processSiblingOf(Model $sibling, $op)
    {
        if ($this->exists and $this->isAncestorOf($sibling)) {
            throw new MoveException('Cant move Ancestor to Descendant');
        }
            Severity: Minor
            Found in src/MaterializedPathTrait.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function makeFirstChildOf has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function makeFirstChildOf($parentId)
    {
        $parent = $this->newQuery()->find($parentId);

        if (!$parent) {
            Severity: Minor
            Found in src/MaterializedPathTrait.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function childrenByDepth has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function childrenByDepth($depth = 0)
    {
        $query = $this->newQuery();
        
        if ($depth == 1) {
            Severity: Minor
            Found in src/MaterializedPathTrait.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function scopeBuildTree has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function scopeBuildTree($query, $parentId = null, $level = null)
    {
        $tree = new Collection();

        if (is_null($parentId)) {
            Severity: Minor
            Found in src/MaterializedPathTrait.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language