Sign upLogin

fga-gpp-mds/2017.1-OndeE-UnB

View on GitHub
Star
darcyWeb/app/assets/javascripts/map/routes/index.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function loadRouteForm has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function loadRouteForm(data) {

  $("#sidebar").load("/map/routes", function() {

    $(".btn-reverse-route").on("click", function(e) {
Severity: Minor
Found in darcyWeb/app/assets/javascripts/map/routes/index.js - About 1 hr to fix

    TODO found
    Open

            // TODO refactor
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js by fixme

    TODO found
    Open

    // TODO Require to fill out origin and destination in the form, before calculate route
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js by fixme

    TODO found
    Open

            // TODO refactor
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js by fixme

    TODO found
    Open

      // TODO Show message when it"s not possible to calculate routes
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js by fixme

    TODO found
    Open

    // TODO Add button to create a new route
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js by fixme

    TODO found
    Open

    // TODO Suggest locations on whe form
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js by fixme

    TODO found
    Open

    // TODO Suggest locations on whe form
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js by fixme

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      } else if (RouteObj.destination.marker !== null && RouteObj.origin.marker === null) {
    console.info("Origin in blank");
    MapObj.createMarker(RouteObj.origin, RouteObj.destination.marker.getLatLng());
    MapObj.removeMarker(RouteObj.destination);
  }
    Severity: Major
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js and 1 other location - About 1 hr to fix
    darcyWeb/app/assets/javascripts/map/routes/index.js on lines 290..298

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (RouteObj.origin.marker !== null && RouteObj.destination.marker === null) {
    console.info("Destination in blank.");
    MapObj.createMarker(RouteObj.destination, RouteObj.origin.marker.getLatLng());
    MapObj.removeMarker(RouteObj.origin);
  } else if (RouteObj.destination.marker !== null && RouteObj.origin.marker === null) {
    Severity: Major
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js and 1 other location - About 1 hr to fix
    darcyWeb/app/assets/javascripts/map/routes/index.js on lines 294..298

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if ("origin" in data) {
    FormObj.origin.val(data.origin);
    FormObj.originText.val(data.origin);
  }
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js and 1 other location - About 40 mins to fix
    darcyWeb/app/assets/javascripts/map/routes/index.js on lines 242..245

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if ("destination" in data) {
    FormObj.destination.val(data.destination);
    FormObj.destinationText.val(data.destination);
  }
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js and 1 other location - About 40 mins to fix
    darcyWeb/app/assets/javascripts/map/routes/index.js on lines 238..241

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        FormObj.destination.parent().find("button").on("click", function() {
      getLocation("destination");
    });
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js and 1 other location - About 35 mins to fix
    darcyWeb/app/assets/javascripts/map/routes/index.js on lines 158..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        FormObj.origin.parent().find("button").on("click", function() {
      getLocation("origin");
    });
    Severity: Minor
    Found in darcyWeb/app/assets/javascripts/map/routes/index.js and 1 other location - About 35 mins to fix
    darcyWeb/app/assets/javascripts/map/routes/index.js on lines 163..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status