Sign upLogin

fh1ch/node-bacstack

View on GitHub
Star
lib/services/cov-notify.js

Summary

Maintainability
C
1 day
Test Coverage

Function decode has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

module.exports.decode = (buffer, offset, apduLen) => {
  let len = 0;
  let result;
  let decodedValue;
  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 0)) return;
Severity: Minor
Found in lib/services/cov-notify.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function decode has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports.decode = (buffer, offset, apduLen) => {
  let len = 0;
  let result;
  let decodedValue;
  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 0)) return;
Severity: Major
Found in lib/services/cov-notify.js - About 3 hrs to fix

    Avoid too many return statements within this function.
    Open

          if (!decodedValue) return;
    Severity: Major
    Found in lib/services/cov-notify.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        if (!baAsn1.decodeIsOpeningTagNumber(buffer, offset + len, 4)) return;
      Severity: Major
      Found in lib/services/cov-notify.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            if (!baAsn1.decodeIsContextTag(buffer, offset + len, 0)) return;
        Severity: Major
        Found in lib/services/cov-notify.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (!baAsn1.decodeIsOpeningTagNumber(buffer, offset + len, 2)) return;
          Severity: Major
          Found in lib/services/cov-notify.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return {
    len: len,
    subscriberProcessId: subscriberProcessId,
    initiatingDeviceId: initiatingDeviceId,
    monitoredObjectId: monitoredObjectId,
            Severity: Major
            Found in lib/services/cov-notify.js - About 30 mins to fix

              TODO found
              Open

                  // TODO: Handle to too large telegrams -> APDU limit
              Severity: Minor
              Found in lib/services/cov-notify.js by fixme

              Parsing error: Invalid ecmaVersion.
              Open

              'use strict';
              Severity: Minor
              Found in lib/services/cov-notify.js by eslint

              For more information visit Source: http://eslint.org/docs/rules/

              There are no issues that match your filters.

              Category
              Status