firebase/emberfire

View on GitHub

Showing 20 of 54 total issues

Function subscribe has 176 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    subscribe(route: Object, model: any, parentModel?: any, relationship?:any) {
        if (!model) { return }
        const store = model.store as DS.Store;
        const modelName = (model.get('type.modelName') || model.get('_internalModel.modelName') || model.modelName) as never
        const modelClass = store.modelFor(modelName) as any;
Severity: Major
Found in addon/services/realtime-listener.ts - About 7 hrs to fix

    Function queryOptionsToQueryFn has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
    Open

    const queryOptionsToQueryFn = (options?:QueryOptions) => (collectionRef:database.Reference) => {
        let ref = collectionRef as ReferenceOrQuery;
        if (options) {
            if (isQueryOnly(options)) { return options.query(collectionRef); }
            if (options.filter) {
    Severity: Minor
    Found in addon/adapters/realtime-database.ts - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function subscribe has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
    Open

        subscribe(route: Object, model: any, parentModel?: any, relationship?:any) {
            if (!model) { return }
            const store = model.store as DS.Store;
            const modelName = (model.get('type.modelName') || model.get('_internalModel.modelName') || model.modelName) as never
            const modelClass = store.modelFor(modelName) as any;
    Severity: Minor
    Found in addon/services/realtime-listener.ts - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function queryOptionsToQueryFn has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

    const queryOptionsToQueryFn = (options?:QueryOptions) => (collectionRef:firestore.CollectionReference) => {
        let ref = collectionRef as CollectionReferenceOrQuery;
        if (options) {
            if (isQueryOnly(options)) { return options.query(collectionRef); }
            if (options.filter) {
    Severity: Minor
    Found in addon/adapters/firestore.ts - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File firestore.ts has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import DS from 'ember-data';
    import { getOwner } from '@ember/application';
    import { pluralize } from 'ember-inflector';
    import { get, set } from '@ember/object';
    import { inject as service } from '@ember/service';
    Severity: Minor
    Found in addon/adapters/firestore.ts - About 2 hrs to fix

      Function includeCollectionRelationships has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const includeCollectionRelationships = (collection: firestore.QuerySnapshot, store: DS.Store, adapter: FirestoreAdapter, snapshot: any, type: any): Promise<firestore.QuerySnapshot> => {
          if (snapshot && snapshot.include) {
              const includes = snapshot.include.split(',') as Array<string>;
              const relationshipsToInclude = includes.map(e => type.relationshipsByName.get(e) as {[key:string]: any}).filter(r => !!r && !r.options.embedded);
              return Promise.all(
      Severity: Minor
      Found in addon/adapters/firestore.ts - About 1 hr to fix

        Function unsubscribe has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                            const unsubscribe = query.onSnapshot(snapshot => {
                                snapshot.docChanges().forEach(change => run(() => {
                                    const normalizedData = serializer.normalizeSingleResponse(store, modelClass, change.doc);
                                    switch(change.type) {
                                        case 'added': {
        Severity: Minor
        Found in addon/services/realtime-listener.ts - About 1 hr to fix

          Function queryOptionsToQueryFn has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const queryOptionsToQueryFn = (options?:QueryOptions) => (collectionRef:database.Reference) => {
              let ref = collectionRef as ReferenceOrQuery;
              if (options) {
                  if (isQueryOnly(options)) { return options.query(collectionRef); }
                  if (options.filter) {
          Severity: Minor
          Found in addon/adapters/realtime-database.ts - About 1 hr to fix

            Function includeRelationships has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const includeRelationships = <T=any>(promise: Promise<T>, store: DS.Store, adapter: FirestoreAdapter, snapshot: any, type: any): Promise<T> => {
                if (snapshot && snapshot.include) {
                    const includes = snapshot.include.split(',') as Array<string>;
                    const relationshipsToInclude = includes.map(e => type.relationshipsByName.get(e) as {[key:string]: any}).filter(r => !!r && !r.options.embedded);
                    const hasManyRelationships = relationshipsToInclude.filter(r => r.meta.kind == 'hasMany');
            Severity: Minor
            Found in addon/adapters/firestore.ts - About 1 hr to fix

              Function queryOptionsToQueryFn has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const queryOptionsToQueryFn = (options?:QueryOptions) => (collectionRef:firestore.CollectionReference) => {
                  let ref = collectionRef as CollectionReferenceOrQuery;
                  if (options) {
                      if (isQueryOnly(options)) { return options.query(collectionRef); }
                      if (options.filter) {
              Severity: Minor
              Found in addon/adapters/firestore.ts - About 1 hr to fix

                Function observeRelationships has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        const observeRelationships = (internalModel: any) => {
                            // HACK HACK HACK
                            const movedKey = '__original___updatePromiseProxyFor';
                            const proxyPromiseListenersKey = `_updatePromiseProxyListeners`;
                            const requestedRelationshipsKey = '_requestedRelationships';
                Severity: Minor
                Found in addon/services/realtime-listener.ts - About 1 hr to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                  if (record) { store.deleteRecord(record) }
                  Severity: Major
                  Found in addon/services/realtime-listener.ts - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                    if (current == null || current.id !== doc.id ) {
                                                        content.insertAt(insertIndex, doc._internalModel);
                                                    }
                    Severity: Major
                    Found in addon/services/realtime-listener.ts - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                      if (existing) { content.removeObject(existing); }
                      Severity: Major
                      Found in addon/services/realtime-listener.ts - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                        if (existing) { content.removeObject(existing); }
                        Severity: Major
                        Found in addon/services/realtime-listener.ts - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                          if (priorKey) {
                                                              const record = content.find((record:any) => record.id === priorKey);
                                                              const index = content.indexOf(record);
                                                              content.insertAt(index+1, doc._internalModel);
                                                          } else {
                          Severity: Major
                          Found in addon/services/realtime-listener.ts - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                                    if (change.newIndex !== change.oldIndex) {
                                                                        content.removeAt(change.oldIndex);
                                                                        content.insertAt(change.newIndex, current)
                                                                    }
                            Severity: Major
                            Found in addon/services/realtime-listener.ts - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                              if (record) { content.removeObject(record); }
                              Severity: Major
                              Found in addon/services/realtime-listener.ts - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                                if (priorKey) {
                                                                    const record = content.find((record:any) => record.id === priorKey);
                                                                    insertIndex = content.indexOf(record) + 1;
                                                                }
                                Severity: Major
                                Found in addon/services/realtime-listener.ts - About 45 mins to fix

                                  Function unsubscribeRoute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                  const unsubscribeRoute = (service: RealtimeListenerService, route: Object, uniqueIdentifier?: string) => {
                                      const routeSubscriptions = get(service, `routeSubscriptions`);
                                      const existingSubscriptions = get(routeSubscriptions, route.toString());
                                      if (existingSubscriptions) {
                                          if (uniqueIdentifier) {
                                  Severity: Minor
                                  Found in addon/services/realtime-listener.ts - About 35 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language