Sign upLogin

fireguard/report

View on GitHub
Star

Showing 3 of 3 total issues

AbstractPhantomExporter has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractPhantomExporter extends AbstractExporter
{
    /**
     * @var string
     */
Severity: Minor
Found in src/Report/Exporters/AbstractPhantomExporter.php - About 2 hrs to fix

    Function addCommandOption has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function addCommandOption($option, $value)
    {
        if ( isset($this->configValidOptions[$option])) {
            $validOptions = $this->configValidOptions[$option];
            if (is_array($validOptions) && in_array($value, $validOptions)) {
    Severity: Minor
    Found in src/Report/Exporters/AbstractPhantomExporter.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mountScriptForExport has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function mountScriptForExport()
    {
        $script = ' 
            var fs = require("fs");
            var args = require("system").args;
    Severity: Minor
    Found in src/Report/Exporters/AbstractPhantomExporter.php - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language