Sign upLogin

fisharebest/webtrees

View on GitHub
Star

Showing 1,726 of 2,403 total issues

Consider simplifying this complex logical expression.
Open

        if (
            $record1 === null ||
            $record2 === null ||
            $record1 === $record2 ||
            $record1->tag() !== $record2->tag() ||
Severity: Major
Found in app/Http/RequestHandlers/MergeFactsAction.php - About 40 mins to fix

    Consider simplifying this complex logical expression.
    Open

            if (
            $record1 === null ||
            $record2 === null ||
            $record1 === $record2 ||
            $record1->tag() !== $record2->tag() ||
    Severity: Major
    Found in app/Http/RequestHandlers/MergeFactsPage.php - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

              if (
            $record1 === null ||
            $record2 === null ||
            $record1 === $record2 ||
            $record1->tag() !== $record2->tag() ||
      Severity: Major
      Found in app/Http/RequestHandlers/MergeRecordsAction.php - About 40 mins to fix

        Consider simplifying this complex logical expression.
        Open

                    if (
                $husb instanceof Individual &&
                $wife instanceof Individual &&
                ($husb->getAllDeathDates() || !$husb->isDead()) &&
                ($wife->getAllDeathDates() || !$wife->isDead())
        Severity: Major
        Found in app/Statistics/Repository/FamilyRepository.php - About 40 mins to fix

          Function calDateClicked has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            webtrees.calDateClicked = function (dateFieldId, dateDivId, year, month, day) {
          Severity: Minor
          Found in resources/js/webtrees.js - About 35 mins to fix

            Method addUrlFavorite has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private function addUrlFavorite(Tree $tree, UserInterface $user, string $url, string $title, string $note): void
            Severity: Minor
            Found in app/Module/UserFavoritesModule.php - About 35 mins to fix

              Method updateCensusAssistant has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function updateCensusAssistant(ServerRequestInterface $request, Individual $individual, string $fact_id, string $newged, bool $keep_chan): string
              Severity: Minor
              Found in app/Module/CensusAssistantModule.php - About 35 mins to fix

                Method individuals has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    protected function individuals(Tree $tree, array $surns_to_show, string $galpha, bool $marnm, bool $fams): Collection
                Severity: Minor
                Found in app/Module/AbstractIndividualListModule.php - About 35 mins to fix

                  Method newGedcomRecord has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      private function newGedcomRecord(string $type, string $xref, string $gedcom, string|null $pending, Tree $tree): GedcomRecord
                  Severity: Minor
                  Found in app/Factories/GedcomRecordFactory.php - About 35 mins to fix

                    Method thumbnailResponse has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            FilesystemOperator $filesystem,
        string $path,
        int $width,
        int $height,
        string $fit
                    Severity: Minor
                    Found in app/Factories/ImageFactory.php - About 35 mins to fix

                      Method mediaFileThumbnailResponse has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              MediaFile $media_file,
        int $width,
        int $height,
        string $fit,
        bool $add_watermark
                      Severity: Minor
                      Found in app/Factories/ImageFactory.php - About 35 mins to fix

                        Method editLinesToGedcom has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function editLinesToGedcom(string $record_type, array $levels, array $tags, array $values, bool $append = true): string
                        Severity: Minor
                        Found in app/Services/GedcomEditService.php - About 35 mins to fix

                          Method handleCollection has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public function handleCollection(ServerRequestInterface $request, Collection $collection, array $search_columns, array $sort_columns, Closure $callback): ResponseInterface
                          Severity: Minor
                          Found in app/Services/DatatablesService.php - About 35 mins to fix

                            Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                protected function search(Tree $tree, string $query, int $offset, int $limit, string $at): Collection
                            Severity: Minor
                            Found in app/Http/RequestHandlers/TomSelectMediaObject.php - About 35 mins to fix

                              Method recordError has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  private function recordError(Tree $tree, string $type, string $xref, string $message, string $tag): object
                              Severity: Minor
                              Found in app/Http/RequestHandlers/CheckTree.php - About 35 mins to fix

                                Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    protected function search(Tree $tree, string $query, int $offset, int $limit, string $at): Collection
                                Severity: Minor
                                Found in app/Http/RequestHandlers/TomSelectRepository.php - About 35 mins to fix

                                  Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      protected function search(Tree $tree, string $query, int $offset, int $limit, string $at): Collection
                                  Severity: Minor
                                  Found in app/Http/RequestHandlers/TomSelectSubmission.php - About 35 mins to fix

                                    Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                        protected function search(Tree $tree, string $query, int $offset, int $limit, string $at): Collection
                                    Severity: Minor
                                    Found in app/Http/RequestHandlers/TomSelectFamily.php - About 35 mins to fix

                                      Method getAnniversaryEvents has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                          public function getAnniversaryEvents(int $jd, string $facts, Tree $tree, string $filterof = '', string $filtersx = ''): array
                                      Severity: Minor
                                      Found in app/Services/CalendarService.php - About 35 mins to fix

                                        Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                            protected function search(Tree $tree, string $query, int $offset, int $limit, string $at): Collection
                                        Severity: Minor
                                        Found in app/Http/RequestHandlers/TomSelectIndividual.php - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language