fisharebest/webtrees

File webtrees.js has 737 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/**
 * webtrees: online genealogy
 * Copyright (C) 2023 webtrees development team
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by

Function reformatDate has 88 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  webtrees.reformatDate = function (datefield, dmy) {
    const months = ['JAN', 'FEB', 'MAR', 'APR', 'MAY', 'JUN', 'JUL', 'AUG', 'SEP', 'OCT', 'NOV', 'DEC'];
    const hijri_months = ['MUHAR', 'SAFAR', 'RABIA', 'RABIT', 'JUMAA', 'JUMAT', 'RAJAB', 'SHAAB', 'RAMAD', 'SHAWW', 'DHUAQ', 'DHUAH'];
    const hebrew_months = ['TSH', 'CSH', 'KSL', 'TVT', 'SHV', 'ADR', 'ADS', 'NSN', 'IYR', 'SVN', 'TMZ', 'AAV', 'ELL'];
    const french_months = ['VEND', 'BRUM', 'FRIM', 'NIVO', 'PLUV', 'VENT', 'GERM', 'FLOR', 'PRAI', 'MESS', 'THER', 'FRUC', 'COMP'];

Function calGenerateSelectorContent has 68 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function calGenerateSelectorContent (dateFieldId, dateDivId, date) {
    let i, j;
    let content = '<table border="1"><tr>';
    content += '<td><select class="form-select" id="' + dateFieldId + '_daySelect" onchange="return webtrees.calUpdateCalendar(\'' + dateFieldId + '\', \'' + dateDivId + '\');">';
    for (i = 1; i < 32; i++) {

Function calLocalize has 20 arguments (exceeds 4 allowed). Consider refactoring.

Open

  webtrees.calLocalize = function (jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec, sun, mon, tue, wed, thu, fri, sat, day) {

Function buildLeafletJsMap has 61 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  webtrees.buildLeafletJsMap = function (id, config, resetCallback) {
    const zoomControl = new L.control.zoom({
      zoomInTitle: config.i18n.zoomIn,
      zoomoutTitle: config.i18n.zoomOut,
    });

Function initializeTomSelect has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  webtrees.initializeTomSelect = function (element) {
    if (element.tomselect) {
      return element.tomselect;
    }

Function calendarWidget has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  webtrees.calendarWidget = function (dateDivId, dateFieldId) {
    let dateDiv = document.getElementById(dateDivId);
    let dateField = document.getElementById(dateFieldId);

    if (dateDiv.style.visibility === 'visible') {

Function autocomplete has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  webtrees.autocomplete = function (selector) {
    // Use typeahead/bloodhound for autocomplete
    $(selector).each(function () {
      const that = this;
      $(this).typeahead(null, {

Function reformatLatLong has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function reformatLatLong (field, pos, neg) {
    // valid LATI or LONG according to Gedcom standard
    // pos (+) : N or E
    // neg (-) : S or W
    let txt = field.value.toUpperCase();

Function buildNameFromParts has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

  webtrees.buildNameFromParts = function (npfx, givn, spfx, surn, nsfx, sex) {

Function calDateClicked has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  webtrees.calDateClicked = function (dateFieldId, dateDivId, year, month, day) {

Avoid too many return statements within this function.

Open

    return new TomSelect(element, { });

Avoid too many return statements within this function.

Open

    return false;

Avoid too many return statements within this function.

Open

    return false;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      if ((dmy === 'MDY' || f2 > 13 && f3 > 31) && f1 <= 12 && f2 <= 31) {
        return f2 + ' ' + months[f1 - 1] + ' ' + (f3 >= 100 ? f3 : (f3 <= yy ? f3 + cc : f3 + cc - 100));
      }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      if ((dmy === 'DMY' || f1 > 13 && f3 > 31) && f1 <= 31 && f2 <= 12) {
        return f1 + ' ' + months[f2 - 1] + ' ' + (f3 >= 100 ? f3 : (f3 <= yy ? f3 + cc : f3 + cc - 100));
      }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      if (RegExp.$1 <= '31' && RegExp.$2 <= '12' && RegExp.$3 > '12') {
        return RegExp.$1 + ' ' + months[RegExp.$2 - 1] + ' ' + RegExp.$3 + RegExp.$4;
      }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      if (RegExp.$1 > '12' && RegExp.$3 <= '12' && RegExp.$4 <= '31') {
        return RegExp.$4 + ' ' + months[RegExp.$3 - 1] + ' ' + RegExp.$1 + RegExp.$2;
      }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (datestr.match(/^(@#DJALALI@|JALALI)( \d?\d )(\d?\d)( \d?\d?\d?\d)$/)) {
      datestr = '@#DJALALI@' + RegExp.$2 + jalali_months[parseInt(RegExp.$3, 10) - 1] + RegExp.$4;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (datestr.match(/^(@#DHEBREW@|HEBREW)( \d?\d )(\d?\d)( \d?\d?\d?\d)$/)) {
      datestr = '@#DHEBREW@' + RegExp.$2 + hebrew_months[parseInt(RegExp.$3, 10) - 1] + RegExp.$4;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        shown: {
          toggle: {
            content: this.dataset.wtHidePasswordText,
            attr: {
              title: this.dataset.wtHidePasswordTitle,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        hidden: {
          toggle: {
            content: this.dataset.wtShowPasswordText,
            attr: {
              title: this.dataset.wtShowPasswordTitle,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  $.fn.dataTableExt.oSort['text-desc'] = function (x, y) {
    return y.localeCompare(x, document.documentElement.lang, { sensitivity: 'base' });
  };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  $.fn.dataTableExt.oSort['text-asc'] = function (x, y) {
    return x.localeCompare(y, document.documentElement.lang, { sensitivity: 'base' });
  };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      container.querySelectorAll('.select-' + select.value + ' select').forEach(element => {
        element.disabled = false;
        if (element.matches('.tom-select')) {
          element.tomselect.enable();
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      container.querySelectorAll('.select-record select').forEach(element => {
        element.disabled = true;
        if (element.matches('.tom-select')) {
          element.tomselect.disable();
        }

• Read up
  Read up