fiunchinho/dmz-controller

View on GitHub

Showing 3 of 11 total issues

Function main has 79 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    // When running as a pod in-cluster, a kubeconfig is not needed. Instead this will make use of the service account injected into the pod.
    // However, allow the use of a local kubeconfig as this can make local development & testing easier.
    kubeconfig := flag.String("kubeconfig", "", "Path to a kubeconfig file")

Severity: Major
Found in main.go - About 2 hrs to fix

    Function main has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
    Open

    func main() {
        // When running as a pod in-cluster, a kubeconfig is not needed. Instead this will make use of the service account injected into the pod.
        // However, allow the use of a local kubeconfig as this can make local development & testing easier.
        kubeconfig := flag.String("kubeconfig", "", "Path to a kubeconfig file")
    
    
    Severity: Minor
    Found in main.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method IngressWhitelister.Whitelist has 5 return statements (exceeds 4 allowed).
    Open

    func (whitelister *IngressWhitelister) Whitelist(key string) error {
        namespace, name, err := cache.SplitMetaNamespaceKey(key)
        if err != nil {
            return fmt.Errorf("Error splitting meta namespace key into parts: %s", err.Error())
        }
    Severity: Major
    Found in ingress_whitelister.go - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language