Sign upLogin

flix-tech/avro-serde-php

View on GitHub
Star

Showing 3 of 5 total issues

Schema has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Schema implements Definition
{
    public static function null(): NullType
    {
        return new NullType();
Severity: Minor
Found in src/Objects/Schema.php - About 2 hrs to fix

    Function applyAttributes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        private function applyAttributes(Schema $schema, SchemaAttributes $attributes): Schema
    {
        foreach ($attributes->options() as $attribute) {
            if ($attribute instanceof VariadicAttribute) {
                $schema = $schema->{$attribute->name()}(...$attribute->value());
    Severity: Minor
    Found in src/Objects/Schema/Generation/SchemaGenerator.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method readDatum has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        AvroIODatumReader $reader,
    AvroStringIO $io,
    AvroSchema $writersSchema,
    AvroSchema $readersSchema,
    $data
    Severity: Minor
    Found in src/Serialize.php - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language