fog/fog-atmos

View on GitHub

Showing 7 of 9 total issues

Method request has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def request(params, &block)
          req_path = params[:path]
          # Force set host and port
          params.merge!({
                          :host     => @storage_host,
Severity: Major
Found in lib/fog/storage/atmos.rb - About 2 hrs to fix

    Method all has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

            def all
              directory ? ns = directory.key : ns = ''
              ns = ns + '/' unless ns =~ /\/$/
              data = service.get_namespace(ns).body[:DirectoryList]
              data = {:DirectoryEntry => []} if data.kind_of? String
    Severity: Minor
    Found in lib/fog/storage/atmos/models/directories.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method request has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

            def request(params, &block)
              req_path = params[:path]
              # Force set host and port
              params.merge!({
                              :host     => @storage_host,
    Severity: Minor
    Found in lib/fog/storage/atmos.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method public_url has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            def public_url(expires = (Time.now + 5 * 365 * 24 * 60 * 60))
              file = directory.files.head(key)
              self.objectid = if file && file.to_s.strip != "" then file.attributes['x-emc-meta'].scan(/objectid=(\w+),/).flatten[0] else nil end
              if self.objectid && self.objectid.to_s.strip != ""
                klass = service.ssl? ? URI::HTTPS : URI::HTTP
    Severity: Minor
    Found in lib/fog/storage/atmos/models/file.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def save(options = {})
              requires :body, :directory, :key
              directory.kind_of?(Directory) ? ns = directory.key : ns = directory
              ns += key
              options[:headers] ||= {}
    Severity: Minor
    Found in lib/fog/storage/atmos/models/file.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method all has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def all(options = {})
              requires :directory
              directory ? ns = directory.key : ns = ''
              ns = ns + '/' unless ns =~ /\/$/
              data = service.get_namespace(ns).body[:DirectoryList]
    Severity: Minor
    Found in lib/fog/storage/atmos/models/files.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def get(key, _options = {})
              return nil if key == '' # Root dir shouldn't be retrieved like this.
              key =~ /\/$/ ? ns = key : ns = key + '/'
              res = service.get_namespace ns
              emc_meta = res.headers['x-emc-meta']
    Severity: Minor
    Found in lib/fog/storage/atmos/models/directories.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language