Sign upLogin

fog/fog-aws

View on GitHub
Star

Showing 630 of 1,221 total issues

Method get_object has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def get_object(bucket_name, object_name, options = {}, &block)
          unless bucket_name
            raise ArgumentError.new('bucket_name is required')
          end
          unless object_name
Severity: Minor
Found in lib/fog/aws/requests/storage/get_object.rb - About 1 hr to fix

    Method get_records has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def get_records(options={})
          shard_iterator = Fog::JSON.decode(options.delete("ShardIterator"))
          limit = options.delete("Limit") || -1
          stream_name = shard_iterator["StreamName"]
          shard_id = shard_iterator["ShardId"]
    Severity: Minor
    Found in lib/fog/aws/requests/kinesis/get_records.rb - About 1 hr to fix

      Method create_load_balancer has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def create_load_balancer(name, options = {})
          params = {}
          params.merge!(Fog::AWS.indexed_param('Subnets.member.%d', options[:subnets]))
          params.merge!(Fog::AWS.indexed_param('SecurityGroups.member.%d', options[:security_groups]))
          params.merge!(Fog::AWS.serialize_keys('Scheme', options[:scheme]))
      Severity: Minor
      Found in lib/fog/aws/requests/elbv2/create_load_balancer.rb - About 1 hr to fix

        Method post_distribution has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def post_distribution(options = {})
          if self.data[:distributions].values.any? { |d| (d['CNAME'] & (options['CNAME']||[])).empty? }
            Fog::AWS::CDN::Mock.error(:invalid_argument, 'CNAME is already in use')
          end
        Severity: Minor
        Found in lib/fog/aws/requests/cdn/post_distribution.rb - About 1 hr to fix

          Method invoke has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def invoke(params={})
          response = Excon::Response.new
          response.status = 200
          response.body = ''
          Severity: Minor
          Found in lib/fog/aws/requests/lambda/invoke.rb - About 1 hr to fix

            Method request has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def request(params)
          refresh_credentials_if_expired
          idempotent   = params.delete(:idempotent)
          parser       = params.delete(:parser)
          action       = params.delete('Action')
            Severity: Minor
            Found in lib/fog/aws/support.rb - About 1 hr to fix

              Method _request has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def _request(body, headers, idempotent, parser)
          @connection.request({
            :body       => body,
            :expects    => 200,
            :headers    => headers,
              Severity: Minor
              Found in lib/fog/aws/rds.rb - About 1 hr to fix

                Method end_element has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                          def end_element(name)
            case name
            when 'member'
              if @in_capabilities
                @response['Capabilities'] << value
                Severity: Minor
                Found in lib/fog/aws/parsers/cloud_formation/get_template_summary.rb - About 1 hr to fix

                  Method end_element has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                            def end_element(name)
            case name
            when 'StreamingDistributionSummary'
              @response['StreamingDistributionSummary'] << @distribution_summary
              @distribution_summary = { 'CNAME' => [], 'TrustedSigners' => [] }
                  Severity: Minor
                  Found in lib/fog/aws/parsers/cdn/get_streaming_distribution_list.rb - About 1 hr to fix

                    Method _request has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            def _request(body, headers, idempotent, parser)
          @connection.request({
                                :body       => body,
                                :expects    => 200,
                                :headers    => headers,
                    Severity: Minor
                    Found in lib/fog/aws/kinesis.rb - About 1 hr to fix

                      Method post_streaming_distribution has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              def post_streaming_distribution(options = {})
          options['CallerReference'] = Time.now.to_i.to_s
          data = '<?xml version="1.0" encoding="UTF-8"?>'
          data << "<StreamingDistributionConfig xmlns=\"http://cloudfront.amazonaws.com/doc/#{@version}/\">"
          for key, value in options
                      Severity: Minor
                      Found in lib/fog/aws/requests/cdn/post_streaming_distribution.rb - About 1 hr to fix

                        Method post_distribution has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                def post_distribution(options = {})
          options['CallerReference'] = Time.now.to_i.to_s
          data = '<?xml version="1.0" encoding="UTF-8"?>'
          data << "<DistributionConfig xmlns=\"http://cloudfront.amazonaws.com/doc/#{@version}/\">"
          for key, value in options
                        Severity: Minor
                        Found in lib/fog/aws/requests/cdn/post_distribution.rb - About 1 hr to fix

                          Method replace_network_acl_entry has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  def replace_network_acl_entry(network_acl_id, rule_number, protocol, rule_action, cidr_block, egress, options = {})
          response = Excon::Response.new
          if self.data[:network_acls][network_acl_id]

            unless self.data[:network_acls][network_acl_id]['entrySet'].find { |r| r['ruleNumber'] == rule_number && r['egress'] == egress }
                          Severity: Minor
                          Found in lib/fog/aws/requests/compute/replace_network_acl_entry.rb - About 1 hr to fix

                            Method revoke_db_security_group_ingress has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    def revoke_db_security_group_ingress(name, opts = {})
          unless opts.key?('CIDRIP') || ((opts.key?('EC2SecurityGroupName') || opts.key?('EC2SecurityGroupId')) && opts.key?('EC2SecurityGroupOwnerId'))
            raise ArgumentError, 'Must specify CIDRIP, or one of EC2SecurityGroupName or EC2SecurityGroupId, and EC2SecurityGroupOwnerId'
          end
                            Severity: Minor
                            Found in lib/fog/aws/requests/rds/revoke_db_security_group_ingress.rb - About 1 hr to fix

                              Method update_event_source_mapping has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      def update_event_source_mapping(params={})
          mapping_id = params.delete('UUID')
          mapping = self.data[:event_source_mappings][mapping_id]

          unless mapping
                              Severity: Minor
                              Found in lib/fog/aws/requests/lambda/update_event_source_mapping.rb - About 1 hr to fix

                                Method delete_attributes has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                        def delete_attributes(domain_name, item_name, attributes = nil)
          response = Excon::Response.new
          if self.data[:domains][domain_name]
            if self.data[:domains][domain_name][item_name]
              if attributes
                                Severity: Minor
                                Found in lib/fog/aws/requests/simpledb/delete_attributes.rb - About 1 hr to fix

                                  Method put_attributes has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                          def put_attributes(domain_name, item_name, attributes, options = {})
          options[:expect] = {} unless options[:expect]
          options[:replace] = [] unless options[:replace]
          response = Excon::Response.new
          if self.data[:domains][domain_name]
                                  Severity: Minor
                                  Found in lib/fog/aws/requests/simpledb/put_attributes.rb - About 1 hr to fix

                                    Method domain_metadata has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                            def domain_metadata(domain_name)
          response = Excon::Response.new
          if domain = self.data[:domains][domain_name]
            response.status = 200
                                    Severity: Minor
                                    Found in lib/fog/aws/requests/simpledb/domain_metadata.rb - About 1 hr to fix

                                      Method request_spot_instances has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                              def request_spot_instances(image_id, instance_type, spot_price, options = {})
          if block_device_mapping = options.delete('LaunchSpecification.BlockDeviceMapping')
            block_device_mapping.each_with_index do |mapping, index|
              for key, value in mapping
                options.merge!({ format("LaunchSpecification.BlockDeviceMapping.%d.#{key}", index) => value })
                                      Severity: Minor
                                      Found in lib/fog/aws/requests/compute/request_spot_instances.rb - About 1 hr to fix

                                        Method describe_task_definition has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                                def describe_task_definition(params={})
          response = Excon::Response.new
          response.status = 200

          taskdef_error = "ClientException => Task Definition can not be blank."
                                        Severity: Minor
                                        Found in lib/fog/aws/requests/ecs/describe_task_definition.rb - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language