fog/fog-exoscale

View on GitHub

Showing 9 of 32 total issues

Method data has 231 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def self.data
          @data ||= begin
            zone_id     = Fog.credentials[:exoscale_zone_id]             || Fog::Exoscale.uuid
            image_id    = Fog.credentials[:exoscale_template_id]         || Fog::Exoscale.uuid
            flavor_id   = Fog.credentials[:exoscale_service_offering_id] || Fog::Exoscale.uuid
Severity: Major
Found in lib/fog/exoscale/compute.rb - About 1 day to fix

    File compute.rb has 396 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "fog/exoscale/core"
    require "digest/md5"
    
    module Fog
      module Compute
    Severity: Minor
    Found in lib/fog/exoscale/compute.rb - About 5 hrs to fix

      Method deploy_virtual_machine has 80 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def deploy_virtual_machine(options={})
                zone_id = options['zoneid']
                unless zone_id
                  raise Fog::Compute::Exoscale::BadRequest.new('Unable to execute API command deployvirtualmachine due to missing parameter zoneid')
                end
      Severity: Major
      Found in lib/fog/exoscale/requests/compute/deploy_virtual_machine.rb - About 3 hrs to fix

        Method authorize_security_group_ingress has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def authorize_security_group_ingress(options={})
                  security_group_id      = options['securitygroupid']
                  security_group_rule_id = Fog::Exoscale.uuid
        
                  unless cidr = options['cidrlist']

          Method authorize_security_group_egress has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def authorize_security_group_egress(options={})
                    security_group_id      = options['securitygroupid']
                    security_group_rule_id = Fog::Exoscale.uuid
          
                    unless cidr = options['cidrlist']

            Method deploy_virtual_machine has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                    def deploy_virtual_machine(options={})
                      zone_id = options['zoneid']
                      unless zone_id
                        raise Fog::Compute::Exoscale::BadRequest.new('Unable to execute API command deployvirtualmachine due to missing parameter zoneid')
                      end
            Severity: Minor
            Found in lib/fog/exoscale/requests/compute/deploy_virtual_machine.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method authorize_security_group_ingress has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                    def authorize_security_group_ingress(options={})
                      security_group_id      = options['securitygroupid']
                      security_group_rule_id = Fog::Exoscale.uuid
            
                      unless cidr = options['cidrlist']

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method authorize_security_group_egress has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                    def authorize_security_group_egress(options={})
                      security_group_id      = options['securitygroupid']
                      security_group_rule_id = Fog::Exoscale.uuid
            
                      unless cidr = options['cidrlist']

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method get has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                    def get(server_id)
                      servers = service.list_virtual_machines('id' => server_id)["listvirtualmachinesresponse"]["virtualmachine"]
                      if servers.nil? || servers.empty?
                        servers = service.list_virtual_machines('id' => server_id, 'projectid' => '-1')["listvirtualmachinesresponse"]["virtualmachine"]
                      end
            Severity: Minor
            Found in lib/fog/exoscale/models/compute/servers.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language