Sign upLogin

fogine/couchbase-odm

View on GitHub
Star
lib/instance.js

Summary

Maintainability
F
5 days
Test Coverage

File instance.js has 653 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';
const _       = require('lodash');
const Promise = require('bluebird');
const util    = require('util');
Severity: Major
Found in lib/instance.js - About 1 day to fix

    Function _getDirtyRefDocs has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Instance.prototype._getDirtyRefDocs = Promise.method(function() {

    const self = this;
    const out = {
        current: [],//collection of current ref-documents which will be persisted to the bucket
    Severity: Major
    Found in lib/instance.js - About 2 hrs to fix

      Function replace has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Instance.prototype.replace = Promise.method(function(options) {

    const self = this;
    let timestampsBck;
    options = options || {};
      Severity: Major
      Found in lib/instance.js - About 2 hrs to fix

        Function Instance has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Instance(data, options) {

    Document.call(this, {
        data        : data,
        key         : options.key,
        Severity: Major
        Found in lib/instance.js - About 2 hrs to fix

          Function _initRelations has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

          Instance.prototype._initRelations =  function() {
    const idPropName   = this._schemaSettings.doc.idPropertyName;
    const modelManager = this.Model._modelManager;
    const relations    = this.Model.relations;
    const dataValues   = this.getData();
          Severity: Minor
          Found in lib/instance.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getSerializedData has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Instance.prototype.getSerializedData = Promise.method(function() {
    const relations = this.Model.relations;
    const instance = this;
    const modelManager = this.Model._modelManager;
          Severity: Minor
          Found in lib/instance.js - About 1 hr to fix

            Function populate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Instance.prototype.populate = Promise.method(function(include, options) {
    const instance = this;
    const defaults = {
        skipPopulated: true,
        getOrFail: false
            Severity: Minor
            Found in lib/instance.js - About 1 hr to fix

              Function destroy has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Instance.prototype.destroy = Promise.method(function(options) {

    const self = this;
    options = options || {};
              Severity: Minor
              Found in lib/instance.js - About 1 hr to fix

                Function _touchTimestamps has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                Instance.prototype._touchTimestamps = function(timestamps, options) {
    options = options || {};

    if (   !this.Model._dataHasObjectStructure()
            || (!this.Model.options.timestamps && !this.Model.options.paranoid)
                Severity: Minor
                Found in lib/instance.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function insert has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Instance.prototype.insert = Promise.method(function(options) {

    const self = this;
    let   report
        , timestampsBck;
                Severity: Minor
                Found in lib/instance.js - About 1 hr to fix

                  Function _touchTimestamps has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  Instance.prototype._touchTimestamps = function(timestamps, options) {
    options = options || {};

    if (   !this.Model._dataHasObjectStructure()
            || (!this.Model.options.timestamps && !this.Model.options.paranoid)
                  Severity: Minor
                  Found in lib/instance.js - About 1 hr to fix

                    Function _cloneData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                    Instance.prototype._cloneData = function(customizer) {
    return _.cloneDeepWith(this.getData(), function(val) {
        if (customizer instanceof Function) {
            let resolved = customizer(val);
            if (resolved !== undefined) {
                    Severity: Minor
                    Found in lib/instance.js - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this function.
                    Open

                                    return Promise.reject(reason);
                    Severity: Major
                    Found in lib/instance.js - About 30 mins to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          return this.Model.runHooks(HookTypes.beforeCreate, this, options).then(function() {

        //validate
        try {
            self.sanitize();
                      Severity: Major
                      Found in lib/instance.js and 2 other locations - About 4 hrs to fix
                      lib/instance.js on lines 715..747
                      lib/instance.js on lines 837..889

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 119.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          return this.Model.runHooks(HookTypes.beforeUpdate, this, options).then(function() {

        //validate & sanitize data
        try {
            self.sanitize();
                      Severity: Major
                      Found in lib/instance.js and 2 other locations - About 4 hrs to fix
                      lib/instance.js on lines 715..747
                      lib/instance.js on lines 771..808

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 119.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          return this.Model.runHooks(HookTypes.beforeDestroy, this, options).then(function() {
        return self.getRefDocs();
    }).bind({}).then(function(docs) {//remove ref docs
        this.docs = docs;
        this.timestamps = self._touchTimestamps(undefined, {touchDeletedAt: true});
                      Severity: Major
                      Found in lib/instance.js and 2 other locations - About 4 hrs to fix
                      lib/instance.js on lines 771..808
                      lib/instance.js on lines 837..889

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 119.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      Instance.prototype.inspect = function() {
    var key = this.options && this.options.key;
    var cas = key && this.options.cas;
    var out = '[object CouchbaseInstance:\n';
    out += "    key: '" + key + "'\n";
                      Severity: Major
                      Found in lib/instance.js and 1 other location - About 3 hrs to fix
                      lib/document.js on lines 266..275

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 104.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status