Sign upLogin

fossasia/loklak_webclient

View on GitHub
Star
app/js/directives/debugged-link.js

Summary

Maintainability
F
3 days
Test Coverage

Function link has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        link: function(scope, element) {
            /**
             * Take the embeded link
             *     Pic.twitter.com is already render in images and is not processed again
             * Debug the link with injected service
Severity: Minor
Found in app/js/directives/debugged-link.js - About 1 hr to fix

    Function findThumb has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var findThumb = function(data) {

        // Loop round 1 finding thumbnail that also has a social media rel
        var keepSearching = true;
        var i = 0;
    Severity: Minor
    Found in app/js/directives/debugged-link.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                                      if (detailedData.indexOf('playerType=facebook') > -1 && detailedData.indexOf('auto_play=false') === -1) {
                                    detailedData = detailedData.replace('playerType=facebook', 'playerType=facebook&auto_play=false');
                                }
      Severity: Major
      Found in app/js/directives/debugged-link.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                        if (moreDetailedData) {
                                    tagToAppend = generateArticleParts(moreDetailedData);
                                }
        Severity: Major
        Found in app/js/directives/debugged-link.js - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              var findThumb = function(data) {

        // Loop round 1 finding thumbnail that also has a social media rel
        var keepSearching = true;
        var i = 0;
          Severity: Major
          Found in app/js/directives/debugged-link.js and 1 other location - About 1 day to fix
          app/js/directives/home-debugged-link.js on lines 52..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 320.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              var generateArticleParts = function(data) {
            var site = (data.site) ? '<a href="' + data.canonical + '" class="article-site">' + data.site + '</a>' : '';
            var title = (data.title) ? '<a href="' + data.canonical + '" class="article-title">' + data.title  + '</a href="' + data.canonical + '">' : '';
            var thumbnail = '<a href="' + data.canonical + '" class="article-img-container"><img src="' + data.thumbnail_url + '"></a href="' + data.canonical + '">';
            var container = '<div class="article-container" href="' + data.canonical + '">';
          Severity: Major
          Found in app/js/directives/debugged-link.js and 1 other location - About 7 hrs to fix
          app/js/directives/home-debugged-link.js on lines 15..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 192.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              var findHtml = function(linkArray) {
        var keepSearching = true;
        var i = 0;
        var result = false;
        while (keepSearching && i < linkArray.length) {
          Severity: Major
          Found in app/js/directives/debugged-link.js and 1 other location - About 4 hrs to fix
          app/js/directives/home-debugged-link.js on lines 29..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 124.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status