Sign upLogin

fossasia/loklak_webclient

View on GitHub
Star
app/js/directives/signin-twitter.js

Summary

Maintainability
D
2 days
Test Coverage

Function controller has 223 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        controller: function($scope) {
            var timelineIntervals = [];
            $rootScope.root.timelineNewTweets = [];
            $rootScope.root.haveNewerTweets = false;
            $rootScope.root.doneGettingFeed = false;
Severity: Major
Found in app/js/directives/signin-twitter.js - About 1 day to fix

    File signin-twitter.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';
/* global angular, $ */
/* jshint unused:false */

var directivesModule = require('./_index.js');
    Severity: Minor
    Found in app/js/directives/signin-twitter.js - About 2 hrs to fix

      Function link has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              link: function(scope) {
            var hello = scope.hello;
            var isOnline = hello('twitter').getAuthResponse();
            var idleTime = 0;
      Severity: Minor
      Found in app/js/directives/signin-twitter.js - About 1 hr to fix

        Function updateTimeline has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        var updateTimeline = function() {
                    console.log("Getting newer tweets");
                    hello(auth.network).api('/me/friends').then(function(twitterFriendFeed) {
                        // Sort by created time to show on timeline
                        twitterFriendFeed.data.sort(function(a,b) {
        Severity: Minor
        Found in app/js/directives/signin-twitter.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                  twitterFriendFeed.data.sort(function(a,b) {
                            if (b.status && a.status) {
                                return new Date(b.status.created_at) - new Date(a.status.created_at);
                            }
                        });
          Severity: Major
          Found in app/js/directives/signin-twitter.js and 1 other location - About 1 hr to fix
          app/js/directives/signin-twitter.js on lines 101..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              twitterFriendFeed.data.sort(function(a,b) {
                        if (b.status && a.status) {
                            return new Date(b.status.created_at) - new Date(a.status.created_at);
                        }
                    });
          Severity: Major
          Found in app/js/directives/signin-twitter.js and 1 other location - About 1 hr to fix
          app/js/directives/signin-twitter.js on lines 124..128

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (!targetClasses || typeof(targetClasses) === "object") {
                    if (!angular.element(".hidden-user-info").hasClass("hide")) {
                        angular.element(".hidden-user-info").toggleClass("hide");
                    }
                } else {
          Severity: Minor
          Found in app/js/directives/signin-twitter.js and 1 other location - About 40 mins to fix
          app/js/directives/signin-twitter.js on lines 221..225

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (targetClasses.indexOf("hidden-user-info") === -1 && targetId.indexOf("home-view-user-avatar") === -1) {
                        if (!angular.element(".hidden-user-info").hasClass("hide")) {
                            angular.element(".hidden-user-info").toggleClass("hide");
                        }
                    }
          Severity: Minor
          Found in app/js/directives/signin-twitter.js and 1 other location - About 40 mins to fix
          app/js/directives/signin-twitter.js on lines 216..226

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status