Sign upLogin

fossasia/loklak_webclient

View on GitHub
Star
iframely/lib/plugins/system/oembed/oembedUtils.js

Summary

Maintainability
C
1 day
Test Coverage

Function getOembed has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports.getOembed = function(uri, options, callback) {

    if (typeof options === 'function') {
        callback = options;
        options = null;
Severity: Major
Found in iframely/lib/plugins/system/oembed/oembedUtils.js - About 2 hrs to fix

    Function lookupStaticProviders has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function lookupStaticProviders(uri) {
    var providers = require('./providers.json');

    var protocolMatch = uri.match(/^(https?:\/\/)/);
    if (!protocolMatch) {
    Severity: Minor
    Found in iframely/lib/plugins/system/oembed/oembedUtils.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function xmlStream2oembed has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function xmlStream2oembed(stream, callback) {
    var oembed;
    var prop;
    var value;
    var firstTag;
    Severity: Minor
    Found in iframely/lib/plugins/system/oembed/oembedUtils.js - About 1 hr to fix

      Function lookupStaticProviders has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function lookupStaticProviders(uri) {
    var providers = require('./providers.json');

    var protocolMatch = uri.match(/^(https?:\/\/)/);
    if (!protocolMatch) {
      Severity: Minor
      Found in iframely/lib/plugins/system/oembed/oembedUtils.js - About 1 hr to fix

        Function findOembedLinks has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports.findOembedLinks = function(uri, meta) {
    // Filter oembed from meta.
    var alternate = meta && meta.alternate;
    if (alternate && !(alternate instanceof Array)) {
        alternate = [alternate];
        Severity: Minor
        Found in iframely/lib/plugins/system/oembed/oembedUtils.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status