Sign upLogin

fossasia/loklak_webclient

View on GitHub
Star
iframely/lib/plugins/validators/sync/07_duplicateLink.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function findBestMedia has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function findBestMedia(m1, m2) {

    if (!m1 && !m2) {
        return m1;
    }
Severity: Minor
Found in iframely/lib/plugins/validators/sync/07_duplicateLink.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prepareLink has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    prepareLink: function(link, pluginContext) {

        if (!link.href) {
            return;
        }
Severity: Minor
Found in iframely/lib/plugins/validators/sync/07_duplicateLink.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findBestMedia has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function findBestMedia(m1, m2) {

    if (!m1 && !m2) {
        return m1;
    }
Severity: Minor
Found in iframely/lib/plugins/validators/sync/07_duplicateLink.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

            return m2;
    Severity: Major
    Found in iframely/lib/plugins/validators/sync/07_duplicateLink.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return m1;
      Severity: Major
      Found in iframely/lib/plugins/validators/sync/07_duplicateLink.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return m2;
        Severity: Major
        Found in iframely/lib/plugins/validators/sync/07_duplicateLink.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return m1;
          Severity: Major
          Found in iframely/lib/plugins/validators/sync/07_duplicateLink.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return (m1.width > m2.width || m1.height > m2.height) ? m1 : m2;
            Severity: Major
            Found in iframely/lib/plugins/validators/sync/07_duplicateLink.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return m2;
              Severity: Major
              Found in iframely/lib/plugins/validators/sync/07_duplicateLink.js - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status