Sign upLogin

fossasia/loklak_webclient

View on GitHub
Star
iframely/modules/tests-ui/tester.js

Summary

Maintainability
F
3 days
Test Coverage

Function processPluginTests has 205 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function processPluginTests(pluginTest, plugin, count, cb) {

    var testUrlsSet, reachTestObjectFound = false;;

    log('===========================================');
Severity: Major
Found in iframely/modules/tests-ui/tester.js - About 1 day to fix

    File tester.js has 444 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    GLOBAL.CONFIG = require('../../config');

if (!CONFIG.tests) {
    console.error('Tests not started: CONFIG.tests not configured.');
    process.abort();
    Severity: Minor
    Found in iframely/modules/tests-ui/tester.js - About 6 hrs to fix

      Function testAll has 133 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function testAll(cb) {

    // Get all plugins with tests.
    var pluginsList = _.values(plugins).filter(function(plugin) {
      Severity: Major
      Found in iframely/modules/tests-ui/tester.js - About 5 hrs to fix

        Function callback has 77 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        function callback(error, data) {

                    if (!timeout) {
                        // TODO: log response error after timeout?
                        return;
        Severity: Major
        Found in iframely/modules/tests-ui/tester.js - About 3 hrs to fix

          Function testAll has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function testAll(cb) {

    // Get all plugins with tests.
    var pluginsList = _.values(plugins).filter(function(plugin) {
          Severity: Minor
          Found in iframely/modules/tests-ui/tester.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function loadPluginTests has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  function loadPluginTests(data, cb) {

            if (testOnePlugin) {
                PluginTest.find({_id: testOnePlugin}, cb);
            } else {
          Severity: Minor
          Found in iframely/modules/tests-ui/tester.js - About 1 hr to fix

            Function getUrls has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    function getUrls(a, cb) {

            var tests = plugin.module.tests;

            if (!tests) {
            Severity: Minor
            Found in iframely/modules/tests-ui/tester.js - About 1 hr to fix

              Function processPluginTests has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              function processPluginTests(pluginTest, plugin, count, cb) {

    var testUrlsSet, reachTestObjectFound = false;;

    log('===========================================');
              Severity: Minor
              Found in iframely/modules/tests-ui/tester.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function updateActualPluginTests(providersIds, cb) {
    PluginTest.update({
        _id: {
            $in: providersIds
        },
              Severity: Major
              Found in iframely/modules/tests-ui/tester.js and 1 other location - About 1 hr to fix
              iframely/modules/tests-ui/tester.js on lines 68..75

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function updateObsoletePluginTests(providersIds, cb) {
    PluginTest.update({
        _id: {
            $nin: providersIds
        },
              Severity: Major
              Found in iframely/modules/tests-ui/tester.js and 1 other location - About 1 hr to fix
              iframely/modules/tests-ui/tester.js on lines 77..84

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status