Sign upLogin

fossasia/loklak_webclient

View on GitHub
Star
iframely/plugins/domains/youtube.com/youtube.video.js

Summary

Maintainability
D
2 days
Test Coverage

Function getData has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    getData: function(urlMatch, request, options, cb) {

        var api_key = options.getProviderOptions('youtube.api_key');

        if (!api_key) {
Severity: Minor
Found in iframely/plugins/domains/youtube.com/youtube.video.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLinks has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    getLinks: function(url, youtube_video_gdata, options) {

        var params = options.getProviderOptions('youtube.get_params', '');

        /** Extract ?t=12m15s, ?t=123, ?start=123, ?stop=123, ?end=123
Severity: Minor
Found in iframely/plugins/domains/youtube.com/youtube.video.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLinks has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getLinks: function(url, youtube_video_gdata, options) {

        var params = options.getProviderOptions('youtube.get_params', '');

        /** Extract ?t=12m15s, ?t=123, ?start=123, ?stop=123, ?end=123
Severity: Major
Found in iframely/plugins/domains/youtube.com/youtube.video.js - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                    if (data.items && data.items.length > 0) {

                    var entry = data.items[0];

                    var duration = 0;
    Severity: Critical
    Found in iframely/plugins/domains/youtube.com/youtube.video.js - About 2 hrs to fix

      Function getData has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getData: function(urlMatch, request, options, cb) {

        var api_key = options.getProviderOptions('youtube.api_key');

        if (!api_key) {
      Severity: Major
      Found in iframely/plugins/domains/youtube.com/youtube.video.js - About 2 hrs to fix

        Function prepareResult has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    prepareResult: function(error, b, data, cb) {

                if (error) {
                    return cb(error);
                }
        Severity: Minor
        Found in iframely/plugins/domains/youtube.com/youtube.video.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  var links = [{
            href: youtube_video_gdata.thumbnails.mq && youtube_video_gdata.thumbnails.mq.url,
            rel: CONFIG.R.thumbnail,
            type: CONFIG.T.image_jpeg,
            width: 320,
          Severity: Major
          Found in iframely/plugins/domains/youtube.com/youtube.video.js and 1 other location - About 1 hr to fix
          iframely/plugins/domains/youtube.com/youtube.video.js on lines 203..209

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      links.push({
                href: youtube_video_gdata.thumbnails.hq && youtube_video_gdata.thumbnails.hq.url,
                rel: CONFIG.R.thumbnail,
                type: CONFIG.T.image_jpeg,
                width: 480,
          Severity: Major
          Found in iframely/plugins/domains/youtube.com/youtube.video.js and 1 other location - About 1 hr to fix
          iframely/plugins/domains/youtube.com/youtube.video.js on lines 166..172

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status