Sign upLogin

fossasia/loklak_webclient

View on GitHub
Star
iframely/plugins/meta/media-detector.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function getMeta has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    getMeta: function(meta, url) {

        // Player.

        var has_player = false;
Severity: Minor
Found in iframely/plugins/meta/media-detector.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getMeta has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getMeta: function(meta, url) {

        // Player.

        var has_player = false;
Severity: Minor
Found in iframely/plugins/meta/media-detector.js - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

                if (/article|blog|news|post|noticia/i.test(url) 
                || (/\/(\d{4})\/(\d{2})\/(\d{2})/).test(url) 
                || (meta.og && meta.og.type && typeof meta.og.type === 'string' && meta.og.type.match(/article|post/i))) {
                
                has_reader = true;
    Severity: Major
    Found in iframely/plugins/meta/media-detector.js - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

                  if ((meta.og.video && !meta.og.type )|| (meta.og.type && typeof meta.og.type === 'string' && meta.og.type.match(/video|movie/i)) || /\/videos?\//i.test(url)) {

                has_player = true;
            }
      Severity: Major
      Found in iframely/plugins/meta/media-detector.js - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status