fossasia/loklak_webclient

View on GitHub
iframely/utils.js

Summary

Maintainability
C
1 day
Test Coverage

Function cacheMiddleware has 132 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    exports.cacheMiddleware = function(req, res, next) {

        async.waterfall([

            function(cb) {
Severity: Major
Found in iframely/utils.js - About 5 hrs to fix

    File utils.js has 277 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function() {
    
        GLOBAL.CONFIG = require('./config');
    
        var async = require('async');
    Severity: Minor
    Found in iframely/utils.js - About 2 hrs to fix

      Function static has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          exports.static = function(root, options){
              options = options || {};
      
              // root required
              if (!root) throw new Error('static() root path required');
      Severity: Minor
      Found in iframely/utils.js - About 1 hr to fix

        Function setResponseToCache has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function setResponseToCache(code, content_type, req, res, body, ttl) {
        Severity: Minor
        Found in iframely/utils.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                              if (jsonpCallback) {
          
                                                  // jsonp case.
          
                                                  var body = data.substring(index + 2);
          Severity: Major
          Found in iframely/utils.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var etag = function(value) {
                    return '"' + crypto.createHash('md5').update(value).digest("hex") + '"';
                };
            Severity: Minor
            Found in iframely/utils.js and 1 other location - About 35 mins to fix
            iframely/lib/request.js on lines 9..11

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status