fossasia/loklak_webclient

View on GitHub
oauth-proxy/api.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function z has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

router.put('/:user/:app/:id', isAuthorized, function z(req, res) {
    getData(req.params.user, function (error, response, body) {
        var responseData = JSON.parse(response.body),
            appData = responseData.accounts[0].apps,
            authData = {},
Severity: Minor
Found in oauth-proxy/api.js - About 1 hr to fix

    Function isAuthorized has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var isAuthorized = function (req, res, next) {
    
        function parseAccessToken(accessToken) {
            var splitted = accessToken.split(":"),
                oauth_token = splitted[0],
    Severity: Minor
    Found in oauth-proxy/api.js - About 1 hr to fix

      Function z has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      router.put('/:user/:app/:id', isAuthorized, function z(req, res) {
          getData(req.params.user, function (error, response, body) {
              var responseData = JSON.parse(response.body),
                  appData = responseData.accounts[0].apps,
                  authData = {},
      Severity: Minor
      Found in oauth-proxy/api.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status