frapposelli/vagrant-vcloud

View on GitHub

Showing 32 of 135 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              if cfg.memory
                if item.at_css('rasd|VirtualQuantity').content != cfg.memory.to_s
                  item.at_css('rasd|VirtualQuantity').content = cfg.memory
                  item.at_css('rasd|ElementName').content = "#{cfg.memory} MB of memory"
                  changed = true
Severity: Minor
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 1 other location - About 25 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 2065..2069

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              if cfg.cpus
                if item.at_css('rasd|VirtualQuantity').content != cfg.cpus.to_s
                  item.at_css('rasd|VirtualQuantity').content = cfg.cpus
                  item.at_css('rasd|ElementName').content = "#{cfg.cpus} virtual CPU(s)"
                  changed = true
Severity: Minor
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 1 other location - About 25 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 2074..2078

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def poweron_vapp(vapp_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vapp-#{vapp_id}/power/action/powerOn"
          }
Severity: Major
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 503..511
lib/vagrant-vcloud/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloud/driver/version_5_1.rb on lines 534..542
lib/vagrant-vcloud/driver/version_5_1.rb on lines 651..659
lib/vagrant-vcloud/driver/version_5_1.rb on lines 666..674
lib/vagrant-vcloud/driver/version_5_1.rb on lines 679..687
lib/vagrant-vcloud/driver/version_5_1.rb on lines 1248..1256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def reboot_vm(vm_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vm-#{vm_id}/power/action/reboot"
          }
Severity: Major
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 503..511
lib/vagrant-vcloud/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloud/driver/version_5_1.rb on lines 534..542
lib/vagrant-vcloud/driver/version_5_1.rb on lines 547..555
lib/vagrant-vcloud/driver/version_5_1.rb on lines 666..674
lib/vagrant-vcloud/driver/version_5_1.rb on lines 679..687
lib/vagrant-vcloud/driver/version_5_1.rb on lines 1248..1256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def reboot_vapp(vapp_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vapp-#{vapp_id}/power/action/reboot"
          }
Severity: Major
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 503..511
lib/vagrant-vcloud/driver/version_5_1.rb on lines 534..542
lib/vagrant-vcloud/driver/version_5_1.rb on lines 547..555
lib/vagrant-vcloud/driver/version_5_1.rb on lines 651..659
lib/vagrant-vcloud/driver/version_5_1.rb on lines 666..674
lib/vagrant-vcloud/driver/version_5_1.rb on lines 679..687
lib/vagrant-vcloud/driver/version_5_1.rb on lines 1248..1256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def suspend_vapp(vapp_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vapp-#{vapp_id}/power/action/suspend"
          }
Severity: Major
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloud/driver/version_5_1.rb on lines 534..542
lib/vagrant-vcloud/driver/version_5_1.rb on lines 547..555
lib/vagrant-vcloud/driver/version_5_1.rb on lines 651..659
lib/vagrant-vcloud/driver/version_5_1.rb on lines 666..674
lib/vagrant-vcloud/driver/version_5_1.rb on lines 679..687
lib/vagrant-vcloud/driver/version_5_1.rb on lines 1248..1256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def reset_vm(vm_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vm-#{vm_id}/power/action/reset"
          }
Severity: Major
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 503..511
lib/vagrant-vcloud/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloud/driver/version_5_1.rb on lines 534..542
lib/vagrant-vcloud/driver/version_5_1.rb on lines 547..555
lib/vagrant-vcloud/driver/version_5_1.rb on lines 651..659
lib/vagrant-vcloud/driver/version_5_1.rb on lines 679..687
lib/vagrant-vcloud/driver/version_5_1.rb on lines 1248..1256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def poweron_vm(vm_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vm-#{vm_id}/power/action/powerOn"
          }
Severity: Major
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 503..511
lib/vagrant-vcloud/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloud/driver/version_5_1.rb on lines 534..542
lib/vagrant-vcloud/driver/version_5_1.rb on lines 547..555
lib/vagrant-vcloud/driver/version_5_1.rb on lines 651..659
lib/vagrant-vcloud/driver/version_5_1.rb on lines 666..674
lib/vagrant-vcloud/driver/version_5_1.rb on lines 1248..1256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def reset_vapp(vapp_id)
          params = {
            'method'  => :post,
            'command' => "/vApp/vapp-#{vapp_id}/power/action/reset"
          }
Severity: Major
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 503..511
lib/vagrant-vcloud/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloud/driver/version_5_1.rb on lines 547..555
lib/vagrant-vcloud/driver/version_5_1.rb on lines 651..659
lib/vagrant-vcloud/driver/version_5_1.rb on lines 666..674
lib/vagrant-vcloud/driver/version_5_1.rb on lines 679..687
lib/vagrant-vcloud/driver/version_5_1.rb on lines 1248..1256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        def redeploy_edge_gateway(edge_gateway_id)
          params = {
            'method'  => :post,
            'command' => "/admin/edgeGateway/#{edge_gateway_id}/action/redeploy"
          }
Severity: Major
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 7 other locations - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 503..511
lib/vagrant-vcloud/driver/version_5_1.rb on lines 519..527
lib/vagrant-vcloud/driver/version_5_1.rb on lines 534..542
lib/vagrant-vcloud/driver/version_5_1.rb on lines 547..555
lib/vagrant-vcloud/driver/version_5_1.rb on lines 651..659
lib/vagrant-vcloud/driver/version_5_1.rb on lines 666..674
lib/vagrant-vcloud/driver/version_5_1.rb on lines 679..687

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def delete_vm(vm_id)
          params = {
            'method'  => :delete,
            'command' => "/vApp/vm-#{vm_id}"
          }
Severity: Minor
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 1 other location - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 467..475

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def delete_vapp(vapp_id)
          params = {
            'method'  => :delete,
            'command' => "/vApp/vapp-#{vapp_id}"
          }
Severity: Minor
Found in lib/vagrant-vcloud/driver/version_5_1.rb and 1 other location - About 20 mins to fix
lib/vagrant-vcloud/driver/version_5_1.rb on lines 562..570

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language