Sign upLogin

freakimkaefig/Music-XML-Analyzer

View on GitHub
Star
public/js/controllers/PatternController.js

Summary

Maintainability
F
6 days
Test Coverage

Function PatternController has a Cognitive Complexity of 78 (exceeds 5 allowed). Consider refactoring.
Open

MusicXMLAnalyzer.PatternController = function() {
    var that = {},
    once = true,
    once2 = true,
    stop = false,
Severity: Minor
Found in public/js/controllers/PatternController.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function PatternController has 243 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MusicXMLAnalyzer.PatternController = function() {
    var that = {},
    once = true,
    once2 = true,
    stop = false,
Severity: Major
Found in public/js/controllers/PatternController.js - About 1 day to fix

    Function playPattern has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        playPattern = function() {
        var notesToBePlayed = [];

        //get notes of current extract:
        var currentPatternNotes = patternModel.getAllNoteElements();
    Severity: Major
    Found in public/js/controllers/PatternController.js - About 2 hrs to fix

      Function init has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          init = function() {
        patternView = MusicXMLAnalyzer.PatternView();
        patternView.init();

        notationView = MusicXMLAnalyzer.NotationView();
      Severity: Minor
      Found in public/js/controllers/PatternController.js - About 1 hr to fix

        Function playTune has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                var playTune = function() {

            if(i < notesToBePlayed.length){
                var note = notesToBePlayed[i].note;
                // how hard the note gets hit
        Severity: Minor
        Found in public/js/controllers/PatternController.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  var playTune = function() {

            if(i < notesToBePlayed.length){
                var note = notesToBePlayed[i].note;
                // how hard the note gets hit
          Severity: Major
          Found in public/js/controllers/PatternController.js and 1 other location - About 2 days to fix
          public/js/controllers/ScoreController.js on lines 143..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 368.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              getDuration = function(type){
        var duration;

        if (type == "whole"){
            duration = 1;
          Severity: Major
          Found in public/js/controllers/PatternController.js and 1 other location - About 5 hrs to fix
          public/js/controllers/ResultController.js on lines 104..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 153.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  $playPattern.click(function(){
            stop = false;
            once2 = true;
            once = true;
            playPattern();
          Severity: Major
          Found in public/js/controllers/PatternController.js and 2 other locations - About 1 hr to fix
          public/js/controllers/ResultController.js on lines 41..48
          public/js/controllers/ScoreController.js on lines 38..45

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  $stopPattern.click(function(){
            stop = true;
            $playPattern.prop('disabled', false);
            $stopPattern.prop('disabled', true);
        });
          Severity: Minor
          Found in public/js/controllers/PatternController.js and 2 other locations - About 35 mins to fix
          public/js/controllers/ResultController.js on lines 50..54
          public/js/controllers/ScoreController.js on lines 47..51

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status