Sign upLogin

freakimkaefig/Music-XML-Analyzer

View on GitHub
Star
public/js/controllers/ResultController.js

Summary

Maintainability
F
3 days
Test Coverage

Function ResultController has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

MusicXMLAnalyzer.ResultController = function(){

    var that = {},

    model = null,
Severity: Minor
Found in public/js/controllers/ResultController.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ResultController has 163 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MusicXMLAnalyzer.ResultController = function(){

    var that = {},

    model = null,
Severity: Major
Found in public/js/controllers/ResultController.js - About 6 hrs to fix

    Function playResult has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        playResult = function(){
        var notesToBePlayed = [];

        //get notes of current extract:
        var currentResultNotes = JSON.parse($('#extract-carousel').find('div.carousel-inner').find('div.item.active').find('.resultExtract').val());
    Severity: Major
    Found in public/js/controllers/ResultController.js - About 3 hrs to fix

      Function init has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          init = function(){
        model = MusicXMLAnalyzer.ResultModel();
        $(model).on('resultExtractReceived', onResultExtractReceived);
        model.init();
      Severity: Minor
      Found in public/js/controllers/ResultController.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                if(typeof noteDuration === 'undefined'){
                            noteDuration = 0.25;
                        }
        Severity: Major
        Found in public/js/controllers/ResultController.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if(note.pitch.dot){
                            noteDuration += 0.5*noteDuration;
                        }
          Severity: Major
          Found in public/js/controllers/ResultController.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if(typeof noteTuplet === 'undefined'){
                            console.log("beam is undefined");
                            noteTuplet = false;
                        }
            Severity: Major
            Found in public/js/controllers/ResultController.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  getDuration = function(type){
        var duration;

        if (type == "whole"){
            duration = 1;
              Severity: Major
              Found in public/js/controllers/ResultController.js and 1 other location - About 5 hrs to fix
              public/js/controllers/PatternController.js on lines 75..95

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 153.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if(currentResultNotes.measures[i].notes[j].type == 'rest'){
                        var rest = currentResultNotes.measures[i].notes[j];
                        var restDuration = getDuration(currentResultNotes.measures[i].notes[j].duration);
                        notesToBePlayed.push({'note': 0, 'noteDuration': restDuration});
              Severity: Major
              Found in public/js/controllers/ResultController.js and 1 other location - About 2 hrs to fix
              public/js/controllers/ScoreController.js on lines 119..138

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 80.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      $playResult.click(function(){
            stop = false;
            once2 = true;
            once = true;
            playResult();
              Severity: Major
              Found in public/js/controllers/ResultController.js and 2 other locations - About 1 hr to fix
              public/js/controllers/PatternController.js on lines 50..57
              public/js/controllers/ScoreController.js on lines 38..45

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 67.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      $stopResult.click(function(){
            stop = true;
            $playResult.prop('disabled', false);
            $stopResult.prop('disabled', true);
        });
              Severity: Minor
              Found in public/js/controllers/ResultController.js and 2 other locations - About 35 mins to fix
              public/js/controllers/PatternController.js on lines 59..63
              public/js/controllers/ScoreController.js on lines 47..51

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status