Sign upLogin

freakimkaefig/Music-XML-Analyzer

View on GitHub
Star
public/js/models/DashboardModel.js

Summary

Maintainability
F
5 days
Test Coverage

Function DashboardModel has a Cognitive Complexity of 72 (exceeds 5 allowed). Consider refactoring.
Open

MusicXMLAnalyzer.DashboardModel = function(){

    var that = {},

    URL_GET_UPLOAD_IDS = "/dashboard/getUploadIds",
Severity: Minor
Found in public/js/models/DashboardModel.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function DashboardModel has 264 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MusicXMLAnalyzer.DashboardModel = function(){

    var that = {},

    URL_GET_UPLOAD_IDS = "/dashboard/getUploadIds",
Severity: Major
Found in public/js/models/DashboardModel.js - About 1 day to fix

    Function _mergeResults has 175 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _mergeResults = function(resultsArr) {
        mergedArr = {
            artist: [],
            clef: null,
            count_measures: 0.0,
    Severity: Major
    Found in public/js/models/DashboardModel.js - About 7 hrs to fix

      File DashboardModel.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /** @constructor */
MusicXMLAnalyzer.DashboardModel = function(){

    var that = {},
      Severity: Minor
      Found in public/js/models/DashboardModel.js - About 2 hrs to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    for (var intervalCounter = 0; intervalCounter < resultsArr[i].value.intervals.length; intervalCounter++) {
                mergedArr.intervals[intervalCounter].value += resultsArr[i].value.intervals[intervalCounter].value;
            }
        Severity: Major
        Found in public/js/models/DashboardModel.js and 3 other locations - About 2 hrs to fix
        public/js/models/DashboardModel.js on lines 339..341
        public/js/models/DashboardModel.js on lines 361..363
        public/js/models/DashboardModel.js on lines 366..368

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    for (var noteCounter = 0; noteCounter < resultsArr[i].value.note_distribution.length; noteCounter++) {
                mergedArr.note_distribution[noteCounter].value += resultsArr[i].value.note_distribution[noteCounter].value;
            }
        Severity: Major
        Found in public/js/models/DashboardModel.js and 3 other locations - About 2 hrs to fix
        public/js/models/DashboardModel.js on lines 334..336
        public/js/models/DashboardModel.js on lines 339..341
        public/js/models/DashboardModel.js on lines 366..368

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    for (var keyCounter = 0; keyCounter < resultsArr[i].value.key.length; keyCounter++) {
                mergedArr.key[keyCounter].value += resultsArr[i].value.key[keyCounter].value;
            }
        Severity: Major
        Found in public/js/models/DashboardModel.js and 3 other locations - About 2 hrs to fix
        public/js/models/DashboardModel.js on lines 334..336
        public/js/models/DashboardModel.js on lines 361..363
        public/js/models/DashboardModel.js on lines 366..368

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    for (var typeCounter = 0; typeCounter < resultsArr[i].value.note_types.length; typeCounter++) {
                mergedArr.note_types[typeCounter].value += resultsArr[i].value.note_types[typeCounter].value;
            }
        Severity: Major
        Found in public/js/models/DashboardModel.js and 3 other locations - About 2 hrs to fix
        public/js/models/DashboardModel.js on lines 334..336
        public/js/models/DashboardModel.js on lines 339..341
        public/js/models/DashboardModel.js on lines 361..363

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status