Sign upLogin

freakimkaefig/Music-XML-Analyzer

View on GitHub
Star
public/js/models/PatternModel.js

Summary

Maintainability
F
1 wk
Test Coverage

Function PatternModel has 470 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MusicXMLAnalyzer.PatternModel = function(){

    var that = {},
    noteElements = [],
    noteElements4VexFlow = [],
Severity: Major
Found in public/js/models/PatternModel.js - About 2 days to fix

    Function PatternModel has a Cognitive Complexity of 113 (exceeds 5 allowed). Consider refactoring.
    Open

    MusicXMLAnalyzer.PatternModel = function(){

    var that = {},
    noteElements = [],
    noteElements4VexFlow = [],
    Severity: Minor
    Found in public/js/models/PatternModel.js - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addNoteElement has 198 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        addNoteElement = function() {

        setValuesForNoteElement();

        if (curMode == 2) {
    Severity: Major
    Found in public/js/models/PatternModel.js - About 7 hrs to fix

      File PatternModel.js has 472 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /** @constructor */
MusicXMLAnalyzer.PatternModel = function(){

    var that = {},
    noteElements = [],
      Severity: Minor
      Found in public/js/models/PatternModel.js - About 7 hrs to fix

        Function setValuesForNoteElement has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            setValuesForNoteElement = function() {

        //accidential
        if (curAccidential == "#") {
            noteElementAccidential = 1;
        Severity: Minor
        Found in public/js/models/PatternModel.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                          if (curName != "break") {
                    noteElements[0].notes.push(
                    {
                        type: "note",
                        pitch: {
          Severity: Major
          Found in public/js/models/PatternModel.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                            if (curName != "break") {
                    noteElements.push(
                    {
                    type: curMode,
                        notes:
            Severity: Major
            Found in public/js/models/PatternModel.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (getCurrentMode() == 1) {
                if (durationContent === "w" || durationContent === "h" || durationContent === "wd" || durationContent === "hd") {
                    keys += '/d0';
                } else {
                    keys += '/d2';
              Severity: Major
              Found in public/js/models/PatternModel.js and 1 other location - About 1 hr to fix
              public/js/views/NotationView.js on lines 188..194

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  {
                                type: "note",
                                pitch: {
                                    step: curName.toUpperCase(),
                                    alter: noteElementAccidential,
              Severity: Minor
              Found in public/js/models/PatternModel.js and 1 other location - About 45 mins to fix
              public/js/models/PatternModel.js on lines 282..292

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                          {
                                type: "note",
                                pitch: {
                                    step: curName.toUpperCase(),
                                    alter: noteElementAccidential,
              Severity: Minor
              Found in public/js/models/PatternModel.js and 1 other location - About 45 mins to fix
              public/js/models/PatternModel.js on lines 313..323

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (curName != "break") {
                    noteElements.push(
                    {
                    type: curMode,
                        notes:
              Severity: Minor
              Found in public/js/models/PatternModel.js and 1 other location - About 35 mins to fix
              public/js/models/PatternModel.js on lines 338..368

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (curName != "break") {
                    noteElements.push(
                    {
                    type: curMode,
                        notes:
              Severity: Minor
              Found in public/js/models/PatternModel.js and 1 other location - About 35 mins to fix
              public/js/models/PatternModel.js on lines 276..309

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (curName == "break") {
            note = new Vex.Flow.StaveNote({ keys: ["b/4"],
                                duration: durationContent + VEXFLOW_REST_SIGN,
                                auto_stem: true });
        } else {
              Severity: Minor
              Found in public/js/models/PatternModel.js and 1 other location - About 30 mins to fix
              public/js/views/NotationView.js on lines 182..198

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status