Sign upLogin

freakimkaefig/Music-XML-Analyzer

View on GitHub
Star
public/js/views/NotationView.js

Summary

Maintainability
F
4 days
Test Coverage

Function NotationView has a Cognitive Complexity of 77 (exceeds 5 allowed). Consider refactoring.
Open

MusicXMLAnalyzer.NotationView = function(){

    var that = {},
    context = null,
    canvas = null,
Severity: Minor
Found in public/js/views/NotationView.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function NotationView has 253 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MusicXMLAnalyzer.NotationView = function(){

    var that = {},
    context = null,
    canvas = null,
Severity: Major
Found in public/js/views/NotationView.js - About 1 day to fix

    Function checkHorizontalArea has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        checkHorizontalArea = function(y) {

        if (y > spaceBetweenLines * 1.25 && y <= spaceBetweenLines * 1.75) {
            hoveredNote = "b";
            hoveredOctave = "6";
    Severity: Major
    Found in public/js/views/NotationView.js - About 3 hrs to fix

      Function renderVexFlowNotePreview has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          renderVexFlowNotePreview = function() {
        // delete canvas
        context.clearRect(0, 0, canvas.width, canvas.height);
        stave.setContext(context).draw();
      Severity: Major
      Found in public/js/views/NotationView.js - About 2 hrs to fix

        File NotationView.js has 255 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /** @constructor */
MusicXMLAnalyzer.NotationView = function(){

    var that = {},
    context = null,
        Severity: Minor
        Found in public/js/views/NotationView.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for(var i=0; i < beams.length; i++) {
            for(var j=0; j < beams[i].length; j++) {
                beams[i][j].setContext(context).draw();
            }
        }
          Severity: Major
          Found in public/js/views/NotationView.js and 1 other location - About 1 hr to fix
          public/js/views/NotationView.js on lines 239..243

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for(var i=0; i < beams.length; i++) {
            for(var j=0; j < beams[i].length; j++) {
                beams[i][j].setContext(context).draw();
            }
        }
          Severity: Major
          Found in public/js/views/NotationView.js and 1 other location - About 1 hr to fix
          public/js/views/NotationView.js on lines 136..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (patternModel.getCurrentMode() === 1) {
                if (durationContent === "w" || durationContent === "h" || durationContent === "wd" || durationContent === "hd") {
                    keys += "/d0";
                } else {
                    keys += "/d2";
          Severity: Major
          Found in public/js/views/NotationView.js and 1 other location - About 1 hr to fix
          public/js/models/PatternModel.js on lines 444..450

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  for(var i=0; i < tuplets.length; i++) {
            tuplets[i].setContext(context).draw();
        }
          Severity: Major
          Found in public/js/views/NotationView.js and 3 other locations - About 50 mins to fix
          public/js/views/NotationView.js on lines 132..134
          public/js/views/ResultView.js on lines 388..390
          public/js/views/ScoreView.js on lines 170..172

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  for(var i=0; i < tuplets.length; i++) {
            tuplets[i].setContext(context).draw();
        }
          Severity: Major
          Found in public/js/views/NotationView.js and 3 other locations - About 50 mins to fix
          public/js/views/NotationView.js on lines 235..237
          public/js/views/ResultView.js on lines 388..390
          public/js/views/ScoreView.js on lines 170..172

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    if (noteName === "break") {
            previewNote = new Vex.Flow.StaveNote({ keys: ["b/4"],
                                duration: durationContent + VEXFLOW_REST_SIGN,
                                auto_stem: true });
        } else {
          Severity: Minor
          Found in public/js/views/NotationView.js and 1 other location - About 30 mins to fix
          public/js/models/PatternModel.js on lines 438..454

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status