Sign upLogin

freedomjs/freedom

View on GitHub
Star
providers/oauth/oauth.remotepageauth.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function launchAuthFlow has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

RemotePageAuth.prototype.launchAuthFlow = function(authUrl, stateObj, interactive, continuation) {
  "use strict";
  var frame = global.document.createElement('iframe');
  frame.src = stateObj.redirect;
  frame.style.display = 'none';
Severity: Minor
Found in providers/oauth/oauth.remotepageauth.js - About 1 hr to fix

Function initiateOAuth has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

RemotePageAuth.prototype.initiateOAuth = function(redirectURIs, continuation) {
  "use strict";
  if (typeof global !== 'undefined' && global && global.document) {
    for (var i=0; i<redirectURIs.length; i++) {
      // TODO: remove restriction on URL pattern match.
Severity: Minor
Found in providers/oauth/oauth.remotepageauth.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status