frisb/fdboost

View on GitHub
lib/enhance/rangereader.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has 196 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  module.exports = function(fdb, debug) {
    var RangeReader, db, iterate, transactionalIterate;
    db = fdb.open();

    /**
Severity: Major
Found in lib/enhance/rangereader.js - About 7 hrs to fix

    Function execute has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          RangeReader.prototype.execute = function(tr, iteratorType) {
            var complete, pastVersionCatchingCallback, toBeContinued, txi;
            if (typeof tr === 'string') {
              iteratorType = tr;
              tr = db;
    Severity: Minor
    Found in lib/enhance/rangereader.js - About 1 hr to fix

      Function getIterator has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            RangeReader.prototype.getIterator = function(tr, callback) {
              var begin, iterator, options, ts;
              debug(function(writer) {
                return writer.log('getIterator');
              });
      Severity: Minor
      Found in lib/enhance/rangereader.js - About 1 hr to fix

        Function RangeReader has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              function RangeReader(options) {
                RangeReader.__super__.constructor.call(this);
                this.begin = options.begin;
                this.end = options.end;
                this.marker = null;
        Severity: Minor
        Found in lib/enhance/rangereader.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            var EventEmitter, resolveKey,
              __hasProp = {}.hasOwnProperty,
              __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; };
          Severity: Major
          Found in lib/enhance/rangereader.js and 1 other location - About 5 hrs to fix
          lib/enhance/encoding/adapters/abstract.js on lines 2..4

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 137.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                RangeReader.prototype.forEachBatch = function(iterator, callback) {
                  var func;
                  func = (function(_this) {
                    return function(arr, next) {
                      _this.emit('data', arr);
          Severity: Major
          Found in lib/enhance/rangereader.js and 1 other location - About 2 hrs to fix
          lib/enhance/rangereader.js on lines 306..315

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                RangeReader.prototype.forEach = function(iterator, callback) {
                  var func;
                  func = (function(_this) {
                    return function(kv, next) {
                      _this.emit('data', kv);
          Severity: Major
          Found in lib/enhance/rangereader.js and 1 other location - About 2 hrs to fix
          lib/enhance/rangereader.js on lines 285..294

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status