fulldump/goconfig

View on GitHub

Showing 12 of 12 total issues

Function FillEnvironments has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
Open

func FillEnvironments(c interface{}) (err error) {

    traverse(c, func(i item) {
        env := strings.ToUpper(strings.Join(i.Path, "_"))
        value := os.Getenv(env)
Severity: Minor
Found in fill_environments.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function unmarshalJSON has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
Open

func unmarshalJSON(data []byte, c interface{}) error {
    if reflect.TypeOf(c).Implements(reflect.TypeOf(new(json.Unmarshaler)).Elem()) {
        if err := json.Unmarshal(data, c); err != nil {
            return errors.New("Bad json file: " + err.Error())
        }
Severity: Minor
Found in fill_json.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function FillArgs has 68 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func FillArgs(c interface{}, args []string) error {
    var f = flag.NewFlagSet(os.Args[0], flag.ContinueOnError)
    f.Usage = func() {}
    f.SetOutput(os.Stdout)

Severity: Minor
Found in fill_args.go - About 1 hr to fix

    Function FillEnvironments has 65 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func FillEnvironments(c interface{}) (err error) {
    
        traverse(c, func(i item) {
            env := strings.ToUpper(strings.Join(i.Path, "_"))
            value := os.Getenv(env)
    Severity: Minor
    Found in fill_environments.go - About 1 hr to fix

      Function unmarshalJSON has 51 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func unmarshalJSON(data []byte, c interface{}) error {
          if reflect.TypeOf(c).Implements(reflect.TypeOf(new(json.Unmarshaler)).Elem()) {
              if err := json.Unmarshal(data, c); err != nil {
                  return errors.New("Bad json file: " + err.Error())
              }
      Severity: Minor
      Found in fill_json.go - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                } else if reflect.Int64 == i.Kind {
                    if v, err := strconv.ParseInt(value, 10, 64); nil == err {
                        set(i.Ptr, &v)
                    }
        
        
        Severity: Major
        Found in fill_environments.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      if v, err := strconv.ParseFloat(value, 32); nil == err {
                          w := float32(v)
                          set(i.Ptr, &w)
                      }
          Severity: Major
          Found in fill_environments.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if d, err = unmarshalDurationString(tmp); err != nil {
                                    return
                                }
            Severity: Major
            Found in fill_json.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if err := json.Unmarshal(value, &tmp); err != nil {
                                      return
                                  }
              Severity: Major
              Found in fill_json.go - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                        } else if reflect.Int == i.Kind {
                            f.IntVar(i.Ptr.(*int), name_path, i.Value.Interface().(int), i.Usage)
                
                        } else if reflect.String == i.Kind {
                            f.StringVar(i.Ptr.(*string), name_path, i.Value.Interface().(string), i.Usage)
                Severity: Major
                Found in fill_args.go - About 45 mins to fix

                  Function unmarshalJSON has 6 return statements (exceeds 4 allowed).
                  Open

                  func unmarshalJSON(data []byte, c interface{}) error {
                      if reflect.TypeOf(c).Implements(reflect.TypeOf(new(json.Unmarshaler)).Elem()) {
                          if err := json.Unmarshal(data, c); err != nil {
                              return errors.New("Bad json file: " + err.Error())
                          }
                  Severity: Major
                  Found in fill_json.go - About 40 mins to fix

                    Function FillArgs has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                    Open

                    func FillArgs(c interface{}, args []string) error {
                        var f = flag.NewFlagSet(os.Args[0], flag.ContinueOnError)
                        f.Usage = func() {}
                        f.SetOutput(os.Stdout)
                    
                    
                    Severity: Minor
                    Found in fill_args.go - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language