Sign upLogin

funlogic-io/zwave-serialapi

View on GitHub
Star
lib/serialapi/hmac.js

Summary

Maintainability
D
2 days
Test Coverage

Function createHmac has 188 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createHmac (params) {
  const events = new EventEmitter()

  const isOpen = new BehaviorSubject(false)
  let openPromise
Severity: Major
Found in lib/serialapi/hmac.js - About 7 hrs to fix

    Function createHmac has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
    Open

    function createHmac (params) {
  const events = new EventEmitter()

  const isOpen = new BehaviorSubject(false)
  let openPromise
    Severity: Minor
    Found in lib/serialapi/hmac.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function close has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function close () {
    if (!isOpen.value) {
      return Promise.resolve()
    } else if (!closePromise) {
      closePromise = openPromise ? openPromise.then(closeInternal) : closeInternal()
    Severity: Minor
    Found in lib/serialapi/hmac.js - About 1 hr to fix

      Function recvFrame has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function recvFrame (frame) {
    events.emit('frame-in', frame)
    log('frame-in: %s', frame.frame.toString('hex'))
    if (frame.valid) {
      if (frame.marker === Const.SOF) {
      Severity: Minor
      Found in lib/serialapi/hmac.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    } else {
              isOpen.next(true)
              openPromise = undefined
              log(`Port ${params.port} opened.`)
              resolve()
        Severity: Minor
        Found in lib/serialapi/hmac.js and 1 other location - About 35 mins to fix
        lib/serialapi/hmac.js on lines 116..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                port.close(() => {
          isOpen.next(false)
          closePromise = undefined
          log(`Port ${params.port} closed.`)
          resolve()
        Severity: Minor
        Found in lib/serialapi/hmac.js and 1 other location - About 35 mins to fix
        lib/serialapi/hmac.js on lines 76..81

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status