Sign upLogin

fuzeman/trakt.py

View on GitHub
Star

Showing 131 of 249 total issues

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    Trakt.configuration.defaults.client(
        id=os.environ.get('CLIENT_ID'),
        secret=os.environ.get('CLIENT_SECRET')
Severity: Major
Found in examples/authentication/device.py and 5 other locations - About 40 mins to fix
examples/authentication/pin.py on lines 70..72
examples/collection.py on lines 15..17
examples/history.py on lines 15..17
examples/lists.py on lines 15..17
examples/scrobbler.py on lines 16..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    def __getstate__(self):
        state = self.__dict__

        if hasattr(self, '_client'):
            del state['_client']
Severity: Major
Found in trakt/objects/media.py and 3 other locations - About 40 mins to fix
trakt/objects/list/base.py on lines 261..267
trakt/objects/person.py on lines 86..92
trakt/objects/rating.py on lines 42..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def all(self, username, rating=None, store=None, **kwargs):
        return self.get(
            username, 'all',
Severity: Major
Found in trakt/interfaces/users/ratings.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def seasons(self, username, sort=None, store=None, **kwargs):
        return self.get(
            username, 'seasons',
Severity: Major
Found in trakt/interfaces/users/watchlist.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def shows(self, username, sort=None, store=None, **kwargs):
        return self.get(
            username, 'shows',
Severity: Major
Found in trakt/interfaces/users/watchlist.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def episodes(self, username, sort=None, store=None, **kwargs):
        return self.get(
            username, 'episodes',
Severity: Major
Found in trakt/interfaces/users/watchlist.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def seasons(self, username, rating=None, store=None, **kwargs):
        return self.get(
            username, 'seasons',
Severity: Major
Found in trakt/interfaces/users/ratings.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def shows(self, username, rating=None, store=None, **kwargs):
        return self.get(
            username, 'shows',
Severity: Major
Found in trakt/interfaces/users/ratings.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def movies(self, username, rating=None, store=None, **kwargs):
        return self.get(
            username, 'movies',
Severity: Major
Found in trakt/interfaces/users/ratings.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def episodes(self, username, rating=None, store=None, **kwargs):
        return self.get(
            username, 'episodes',
Severity: Major
Found in trakt/interfaces/users/ratings.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/watchlist.py on lines 77..80
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @authenticated
    def movies(self, username, sort=None, store=None, **kwargs):
        return self.get(
            username, 'movies',
Severity: Major
Found in trakt/interfaces/users/watchlist.py and 8 other locations - About 35 mins to fix
trakt/interfaces/users/ratings.py on lines 74..77
trakt/interfaces/users/ratings.py on lines 83..86
trakt/interfaces/users/ratings.py on lines 92..95
trakt/interfaces/users/ratings.py on lines 101..104
trakt/interfaces/users/ratings.py on lines 110..113
trakt/interfaces/users/watchlist.py on lines 86..89
trakt/interfaces/users/watchlist.py on lines 95..98
trakt/interfaces/users/watchlist.py on lines 104..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language