Sign upLogin

fy0/slim

View on GitHub
Star
slim_cli/template/tools/netapi.js

Summary

Maintainability
C
1 day
Test Coverage

Function createAPIRequester has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function createAPIRequester (ctx) {
    function getAccessToken () {
        if (!ctx) {
            return localStorage.getItem('t')
        }
Severity: Major
Found in slim_cli/template/tools/netapi.js - About 4 hrs to fix

    Function createAPIRequester has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

    export function createAPIRequester (ctx) {
    function getAccessToken () {
        if (!ctx) {
            return localStorage.getItem('t')
        }
    Severity: Minor
    Found in slim_cli/template/tools/netapi.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function doRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        async function doRequest (url, method, params, data = null, role = null) {
    Severity: Minor
    Found in slim_cli/template/tools/netapi.js - About 35 mins to fix

      Function filterValues has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function filterValues (filter, data) {
    let keys = null
    if (_.isArray(filter)) keys = new Set(filter)
    else if (_.isSet(filter)) keys = filter
    else if (_.isFunction(filter)) return filter(data)
      Severity: Minor
      Found in slim_cli/template/tools/netapi.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              async set (params, data, role = null, filter = null) {
            if (filter) data = filterValues(filter, data)
            return doPost(`${this.urlPrefix}/update`, params, data, role)
        }
      Severity: Major
      Found in slim_cli/template/tools/netapi.js and 1 other location - About 1 hr to fix
      slim_cli/template/tools/netapi.js on lines 126..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              async update (params, data, role = null, filter = null) {
            if (filter) data = filterValues(filter, data)
            return doPost(`${this.urlPrefix}/update`, params, data, role)
        }
      Severity: Major
      Found in slim_cli/template/tools/netapi.js and 1 other location - About 1 hr to fix
      slim_cli/template/tools/netapi.js on lines 121..124

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status