Sign upLogin

gadael/gadael

View on GitHub
Star
api/Company.api.js

Summary

Maintainability
D
2 days
Test Coverage

File Company.api.js has 428 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

const models = require('../models');
const helmet = require('helmet');
const routes = require('../rest/routes');
Severity: Minor
Found in api/Company.api.js - About 6 hrs to fix

    Function getExpress has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        getExpress: function getExpress(config, models) {

        let mongoStore = connectMongodbSession(session);
    Severity: Major
    Found in api/Company.api.js - About 3 hrs to fix

      Function createDb has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          createDb: function createDb(app, dbName, company) {
        if (undefined !== app.db && Object.keys(app.db.models).length > 0) {
            return Promise.reject(new Error('app object already initialized with models'));
        }
      Severity: Minor
      Found in api/Company.api.js - About 1 hr to fix

        Function startServer has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            startServer: function startServer(app, callback) {

        const server = http.createServer(app);
        const companyModel = app.db.models.Company;
        Severity: Minor
        Found in api/Company.api.js - About 1 hr to fix

          Function getCompanies has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              getCompanies: function getCompanies(app, ignoreList) {

        let api = this;
        if (undefined === ignoreList) {
            ignoreList = [];
          Severity: Minor
          Found in api/Company.api.js - About 1 hr to fix

            Function getHighestPort has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                getHighestPort: function getHighestPort(app, callback) {
        this.getCompanies(app).then(companies => {

            var max = 0;
            for (let dbName in companies) {
            Severity: Minor
            Found in api/Company.api.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function isDbNameValid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                isDbNameValid: function isDbNameValid(app, dbName, callback) {


        if (!dbName.match(/[a-z0-9]+/gi) || dbName.length <= 2 || dbName.length > 100)
        {
            Severity: Minor
            Found in api/Company.api.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        db = app.mongoose.createConnection('mongodb://' + app.config.mongodb.prefix + dbName,
                { useNewUrlParser: true, useCreateIndex: true });
            Severity: Minor
            Found in api/Company.api.js and 1 other location - About 50 mins to fix
            api/Company.api.js on lines 291..292

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            db = app.mongoose.createConnection('mongodb://' + app.config.mongodb.prefix + dbName,
                    { useNewUrlParser: true, useCreateIndex: true });
            Severity: Minor
            Found in api/Company.api.js and 1 other location - About 50 mins to fix
            api/Company.api.js on lines 370..371

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status