gadael/gadael

View on GitHub
api/Department.api.js

Summary

Maintainability
C
1 day
Test Coverage

Function populateScreenshots has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

api.populateScreenshots = function(app, department) {

    let userApi = require('./User.api');

    let promises = [];
Severity: Minor
Found in api/Department.api.js - About 1 hr to fix

    Function populate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    api.populate = function(app, department, nbUsers, password) {
    
        const Charlatan = require('charlatan');
        let userApi = require('./User.api');
    
    
    Severity: Minor
    Found in api/Department.api.js - About 1 hr to fix

      Function create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      api.create = function(app, parent, name, operator) {
      
          const Charlatan = require('charlatan');
          const DepartmentModel = app.db.models.Department;
      
      
      Severity: Minor
      Found in api/Department.api.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            return Promise.all(promises)
            .then(randomUsers => {
                return randomUsers[0].user.getManager()
                .then(managerDocument => {
                    managerDocument.department = [department._id];
        Severity: Major
        Found in api/Department.api.js and 1 other location - About 3 hrs to fix
        api/Department.api.js on lines 130..149

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            return Promise.all(promises)
            .then(randomUsers => {
                return randomUsers[0].user.getManager()
                .then(managerDocument => {
                    managerDocument.department = [department._id];
        Severity: Major
        Found in api/Department.api.js and 1 other location - About 3 hrs to fix
        api/Department.api.js on lines 85..104

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    api.populate(app, department, nbUsers, password)
                    .then(randomUsers => {
        
                        let randomDepartment = {
                            department: department,
        Severity: Minor
        Found in api/Department.api.js and 1 other location - About 30 mins to fix
        api/Department.api.js on lines 203..213

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    api.populateScreenshots(app, department)
                    .then(randomUsers => {
        
                        let randomDepartment = {
                            department: department,
        Severity: Minor
        Found in api/Department.api.js and 1 other location - About 30 mins to fix
        api/Department.api.js on lines 176..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status